Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports for 1.1.0 #3869

Merged
merged 12 commits into from
Jun 21, 2024
Merged

Backports for 1.1.0 #3869

merged 12 commits into from
Jun 21, 2024

Conversation

benlorenz
Copy link
Member

@benlorenz benlorenz commented Jun 18, 2024 •
edited
Loading

joschmitt and others added 2 commits June 18, 2024 14:20
@joschmitt @benlorenz
Fix some combinatorics (#3860)
0ddf6de 
* Make sure the combinatorics functions work for every integer type

* Fix `is_standard` for negative values

* Fix documentation of Schur polynomials

* Fix `schur_polynomial`

* Change one-line/terse printing of tableaux

(cherry picked from commit 265e89c)
@thofma @aaruni96
fix: change idel to idele and improve printing (#3859)
78a2368 
(cherry picked from commit 268c5f1)
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.85590% with 53 lines in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (3a2bfe3) to head (6f0049a).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.1    #3869      +/-   ##
===============================================
+ Coverage        81.83%   81.92%   +0.09%     
===============================================
  Files              581      581              
  Lines            80009    80075      +66     
===============================================
+ Hits             65475    65603     +128     
+ Misses           14534    14472      -62
Files Coverage Δ
...heoryTools/src/AbstractFTheoryModels/attributes.jl 97.84% <100.00%> (+0.09%) ⬆️
...heoryTools/src/AbstractFTheoryModels/properties.jl 100.00% <100.00%> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 89.47% <100.00%> (+0.32%) ⬆️
...perimental/Schemes/src/CoveredProjectiveSchemes.jl 88.30% <100.00%> (-0.06%) ⬇️
experimental/Schemes/src/LazyGluing.jl 98.18% <100.00%> (+0.10%) ⬆️
...ental/Schemes/src/MorphismFromRationalFunctions.jl 42.59% <100.00%> (+2.66%) ⬆️
experimental/Schemes/src/WeilDivisor.jl 60.00% <100.00%> (+0.47%) ⬆️
...aicGeometry/Schemes/Covering/Objects/Attributes.jl 98.07% <100.00%> (+0.07%) ⬆️
...mbinatorics/EnumerativeCombinatorics/partitions.jl 96.94% <100.00%> (ø)
...rics/EnumerativeCombinatorics/schur_polynomials.jl 98.44% <100.00%> (+17.49%) ⬆️
... and 10 more

... and 3 files with indirect coverage changes

emikelsons and others added 8 commits June 19, 2024 11:41
@emikelsons @benlorenz
Added more attributes including gauge algebras (#3822)
14e6591 
[FtheoryTools] More attributes including gauge algebras:

Added torsion sections to the attributes
Added gauge algebras for almost all models including parametric models
Fixed some arxiv ids(removed v2)
Changed model information so that the gauge algebra constructor can parse it.

(cherry picked from commit a1cce05)
@HechtiDerLachs @benlorenz
Fibration hopping presentation (#3839)
d9a3ab6 
* Add error message to warn the user about a particular failure in Singular.

* select a good chart for subsystems of a linear system

* Factor denominators for mappings.

* Tune convert routine.

* improve is_one for SumIdealSheaf

* Repair _maximal_associated_points.

* Improve arithmetic of elements in localizations of quotients.

* has_is_prime for ideal sheaves

* view the trivial gluing as computed

---------

Co-authored-by: Simon Brandhorst <[email protected]>
(cherry picked from commit 7877cd7)
@fieker @benlorenz
fixes (hopefully) #3841 (#3866)
6f0049a 
No test as this is the result of (bad) random choices internally, based
on flawed mathematics

(cherry picked from commit bd3e646)
@HereAround @benlorenz
[FTheoryTools] Remove outdated comment
b4a0d92 
(cherry picked from commit fd1f6de)
@HereAround @benlorenz
[FTheoryTools] Overhall the F-theory QSMs
0555518 
(cherry picked from commit 902c497)
@HereAround @benlorenz
[FTheoryTools] Remove unused method
43cb365 
(cherry picked from commit 1c7d9d5)
@HechtiDerLachs @benlorenz
Some more fixes for the fibration hopping. (#3877)
0e1cc8c 
* Some fixes in the production of ideal sheaves.

* give the compiler a hint in order to avoid an infinite recursion

---------

Co-authored-by: Simon Brandhorst <[email protected]>
(cherry picked from commit 58abe47)
@benlorenz
Version 1.1.0
52177f7
@benlorenz benlorenz marked this pull request as ready for review June 21, 2024 07:07
@benlorenz benlorenz force-pushed the backports-release-1.1 branch from f85a4a8 to 7a96c95 Compare June 21, 2024 08:37
@benlorenz benlorenz merged commit d0b75de into release-1.1 Jun 21, 2024
23 of 26 checks passed
@benlorenz benlorenz deleted the backports-release-1.1 branch June 21, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@benlorenz @joschmitt @thofma @emikelsons @HechtiDerLachs @fieker @HereAround