Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes (hopefully) #3841 #3866

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fixes (hopefully) #3841 #3866

merged 1 commit into from
Jun 18, 2024

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Jun 17, 2024

No test as this is the result of (bad) random choices internally, based on flawed mathematics

fixes #3841

No test as this is the result of (bad) random choices internally, based
on flawed mathematics
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.83%. Comparing base (8a1076f) to head (7795ffc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3866   +/-   ##
=======================================
  Coverage   81.83%   81.83%           
=======================================
  Files         581      581           
  Lines       80009    80011    +2     
=======================================
+ Hits        65475    65477    +2     
  Misses      14534    14534           
Files Coverage Δ
experimental/GModule/src/GaloisCohomology.jl 67.92% <83.33%> (+0.05%) ⬆️

@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Jun 17, 2024
@fieker fieker merged commit bd3e646 into master Jun 18, 2024
30 checks passed
@fieker fieker deleted the GalFix3 branch June 18, 2024 07:47
@fieker fieker added backport 1.0.x Should be backported to the release 1.0 branch backport 1.1.x backport for release 1.1 labels Jun 19, 2024
benlorenz pushed a commit that referenced this pull request Jun 19, 2024
No test as this is the result of (bad) random choices internally, based
on flawed mathematics

(cherry picked from commit bd3e646)
@aaruni96 aaruni96 mentioned this pull request Jun 19, 2024
9 tasks
@benlorenz benlorenz removed the backport 1.1.x backport for release 1.1 label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.x Should be backported to the release 1.0 branch experimental Only changes experimental parts of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failure in G-Module tests
3 participants