Mjrodgers ow g modules #4108
Open
Mjrodgers ow g modules #4108
+347
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fieker
force-pushed
the
mjrodgers-OW_GModules
branch
2 times, most recently
from
0c125cd to
6d4c896
Compare
4 tasks
the "same" should work for Pc - but we don't have the interface to sanely query the pc-relations (yet)
create an Oscar collector from a GAP collector
Co-authored-by: Lars Göttgens <[email protected]>
the following should/ will work: C = trivial_gmodule(pc_group(symmetric_group(4)), abelian_group([2,3])) q = cohomology_group(C, 2); h = q[2](q[1][1]) E = extension(h) m1 = isomorphism(FPGroup, E) m2 = isomorphism(PcGroup, E) is_isomorphic(codomain(m1), codomain(m2)) However, m2 will not work as a map, there is code missing to legally convert a syllable back into a PcGroup Or a shiftgens for PcGroups The syllables function for Pc is possibly dodgy
create an Oscar collector from a GAP collector
fieker
force-pushed
the
mjrodgers-OW_GModules
branch
from
dd53042 to
5f02019
Compare
via abelian groups. This should work now: Zx, x = ZZ[:x]; k, a= number_field(swinnerton_dyer(4, x)) zk = lll(maximal_order(k)) p2 = prime_decomposition(zk, 2); C, mC = completion(k, p2[1][1]); G = gmodule(C); z = free_abelian_group(1) h = hom((G[1]).M, z, [z([Int(absolute_ramification_index(C)*valuation(G[3](x)))]) for x = gens((G[1]).M)]) hom(G[1], trivial_gmodule((G[1]).G, z), h) U = kernel(ans) cohomology_group(U[1], 1)[1]
create an Oscar collector from a GAP collector
Note that `conductor` got corrected in a previous commit.
- call `extension(FPGroup, c)` instead of `extension(c)`
- in `invariant_lattice_classes`, put not the result of `sub`
into the result but its first component
- a prescribed test result was wrong, now it is corrent
- `Map{T1,T2}` does actually not match the type of a
`AbstractAlgebra.Generic.ModuleHomomorphism`
(although domain and codomain are correct)
|
@fieker Commit 1cd8833 proposes some syntax changes in order to make the tests pass. I am not sure that this is a good solution. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4108 +/- ##
==========================================
- Coverage 84.40% 84.24% -0.16%
==========================================
Files 656 664 +8
Lines 87216 88110 +894
==========================================
+ Hits 73612 74232 +620
- Misses 13604 13878 +274
|
|
looks good! Clearly we need more tests... but that is independent of this PR |
|
On Fri, Dec 13, 2024 at 05:54:13AM -0800, Thomas Breuer wrote:
@fieker Commit 1cd8833 proposes some syntax changes in order to make the tests pass. I am not sure that this is a good solution.
The problem was that `extension(c)` was called where apparently the two argument version `extension(FPGroup, c)` is needed.
(Where is the variant `extension(c)` needed, which returns a `GrpExt` object?)
In GrpExt.jl - in this PR, a new file.
…
--
Reply to this email directly or view it on GitHub:
#4108 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
|
|
This is just #4402. |
…em/Oscar.jl into mjrodgers-OW_GModules
lgoettgens
reviewed
Jan 10, 2025
| return c | ||
| else | ||
| return div(c, 2) | ||
| end | ||
| return c |
There was a problem hiding this comment.
this return is unreachable
Suggested change
| return c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.