Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjrodgers ow g modules #4108

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Merge branch 'mjrodgers-OW_GModules' of https://github.com/oscar-syst…

90925f0
Select commit
Loading
Failed to load commit list.
Open

Mjrodgers ow g modules #4108

Merge branch 'mjrodgers-OW_GModules' of https://github.com/oscar-syst…
90925f0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 1s

84.24% (-0.16%) compared to 23b0b9d

View this Pull Request on Codecov

84.24% (-0.16%) compared to 23b0b9d

Details

Codecov Report

Attention: Patch coverage is 16.04278% with 157 lines in your changes missing coverage. Please review.

Project coverage is 84.24%. Comparing base (23b0b9d) to head (90925f0).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
experimental/GModule/src/GrpExt.jl 1.78% 110 Missing ⚠️
experimental/GModule/src/Types.jl 25.00% 30 Missing ⚠️
experimental/GModule/src/GModule.jl 40.00% 15 Missing ⚠️
experimental/GModule/src/Misc.jl 50.00% 1 Missing ⚠️
src/Rings/AbelianClosure.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4108      +/-   ##
==========================================
- Coverage   84.40%   84.24%   -0.16%     
==========================================
  Files         656      664       +8     
  Lines       87216    88110     +894     
==========================================
+ Hits        73612    74232     +620     
- Misses      13604    13878     +274     
Files with missing lines Coverage Δ
experimental/GModule/src/Cohomology.jl 72.72% <100.00%> (-0.87%) ⬇️
experimental/GModule/test/runtests.jl 100.00% <ø> (ø)
src/GAP/iso_oscar_gap.jl 98.26% <100.00%> (+<0.01%) ⬆️
experimental/GModule/src/Misc.jl 45.59% <50.00%> (+0.03%) ⬆️
src/Rings/AbelianClosure.jl 93.96% <66.66%> (-0.32%) ⬇️
experimental/GModule/src/GModule.jl 63.34% <40.00%> (-0.51%) ⬇️
experimental/GModule/src/Types.jl 25.00% <25.00%> (ø)
experimental/GModule/src/GrpExt.jl 36.19% <1.78%> (-28.03%) ⬇️

... and 58 files with indirect coverage changes