Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fork #1

Merged
merged 23 commits into from
Jun 12, 2020
Merged

update fork #1

merged 23 commits into from
Jun 12, 2020

Conversation

oscar-zyh
Copy link
Owner

What problem does this PR solve?

update fork

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-cdc/cdc-ansible

Release note

amyangfei and others added 23 commits June 4, 2020 15:35
* cyclic: create mark tables if cyclic is enabled

Signed-off-by: Neil Shen <[email protected]>

* Update cmd/client_changefeed.go
* Update cmd/client_changefeed.go
* Update pkg/cyclic/mark.go
* Update pkg/cyclic/mark.go

Co-authored-by: amyangfei <[email protected]>
* cyclic: prefer hyphen delimiter
* cyclic: do not create mark table for mark table

Signed-off-by: Neil Shen <[email protected]>
* enable support for autorandom in tidb sink

* use dsn string to set session variable

* reformat code

* CI test

* fix CI test config

* add special comments

* log AddSpecialComment

* log AddSpecialComment

* add special comments for all sinks

* fix CI

* add error messages for configureSinkURI

* change import order
@oscar-zyh oscar-zyh merged commit a6e7a2b into oscar-zyh:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants