feat(alerting): magic alerting severities #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hy3n4 <[email protected]>
fourstepper
force-pushed
the
feature/auto-alert-rule
branch
from
6f30998 to
484b459
Compare
Signed-off-by: Robin Opletal <[email protected]>
Signed-off-by: Robin Opletal <[email protected]>
Signed-off-by: Robin Opletal <[email protected]>
Signed-off-by: Robin Opletal <[email protected]>
fourstepper
force-pushed
the
feature/auto-alert-rule
branch
from
742c1a6 to
55c7d2a
Compare
This was referenced Sep 24, 2024
fourstepper
commented
Sep 28, 2024
fourstepper
commented
Sep 28, 2024
fourstepper
commented
Oct 1, 2024
Signed-off-by: Robin Opletal <[email protected]>
fourstepper
force-pushed
the
feature/auto-alert-rule
branch
from
739c82c to
f6de5e2
Compare
|
Closes #103 |
when deploying dev infratructure Signed-off-by: Hy3n4 <[email protected]>
* feat(alerting): alertmanager config loader Signed-off-by: Robin Opletal <[email protected]> * generated stuff... Signed-off-by: Robin Opletal <[email protected]> --------- Signed-off-by: Robin Opletal <[email protected]>
Signed-off-by: Jose Santorum <[email protected]>
Hy3n4
force-pushed
the
feature/auto-alert-rule
branch
3 times, most recently
from
809ab8d to
38e56e7
Compare
mainly fixed duration issues also, added some feature to devel, osko dashboards, kustomize for asier deployment and other cool stuff modified function responsible for creating the alerting rule when magiAlerting is enabled, also added some basic mapping for opsgenie, pagerduty and custom alerting tool. Currently not working as expected tho Signed-off-by: Hy3n4 <[email protected]>
Hy3n4
force-pushed
the
feature/auto-alert-rule
branch
from
38e56e7 to
6b30062
Compare
Signed-off-by: Hy3n4 <[email protected]>
fourstepper
commented
Dec 27, 2024
fourstepper
commented
Dec 27, 2024
Comment on lines
+297
to
+300
| if baseWindow == "5m" || baseWindow == "30m" || baseWindow == "1h" || baseWindow == "6h" || | ||
| baseWindow == "24h" || baseWindow == "3d" || baseWindow == "2h" { | ||
| alertRuleErrorBudgets = append(alertRuleErrorBudgets, rules["burnRate"][baseWindow]) | ||
| } |
There was a problem hiding this comment.
what are we trying to do with the if?
…nings Signed-off-by: Robin Opletal <[email protected]>
Signed-off-by: Robin Opletal <[email protected]>
fourstepper
force-pushed
the
feature/auto-alert-rule
branch
from
b26a8d6 to
795e620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.