Properly log error (#5862)

(cherry picked from commit 8275750)
osmosis-labs · Jul 28, 2023 · 010ad66 · 010ad66
1 parent 5660821
commit 010ad66
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/x/protorev/keeper/hooks.go b/x/protorev/keeper/hooks.go
@@ -102,7 +102,7 @@ func (k Keeper) StoreSwap(ctx sdk.Context, poolId uint64, tokenIn, tokenOut stri
 	}
 
 	if err := k.AddSwapsToSwapsToBackrun(ctx, []types.Trade{swapToBackrun}); err != nil {
-		ctx.Logger().Error("Protorev error adding swap to backrun from storeSwap", err) // Does not return since logging is last thing in the function
+		ctx.Logger().Error("Protorev error adding swap to backrun from storeSwap: " + err.Error()) // Does not return since logging is last thing in the function
 	}
 }
 
@@ -155,7 +155,7 @@ func (k Keeper) StoreJoinExitPoolSwaps(ctx sdk.Context, sender sdk.AccAddress, p
 func (k Keeper) AfterPoolCreatedWithCoins(ctx sdk.Context, poolId uint64) {
 	baseDenoms, err := k.GetAllBaseDenoms(ctx)
 	if err != nil {
-		ctx.Logger().Error("Protorev error getting base denoms in AfterCFMMPoolCreated hook", err)
+		ctx.Logger().Error("Protorev error getting base denoms in AfterCFMMPoolCreated hook: " + err.Error())
 		return
 	}
 
@@ -166,13 +166,13 @@ func (k Keeper) AfterPoolCreatedWithCoins(ctx sdk.Context, poolId uint64) {
 
 	pool, err := k.poolmanagerKeeper.GetPool(ctx, poolId)
 	if err != nil {
-		ctx.Logger().Error("Protorev error getting pool in AfterCFMMPoolCreated hook", err)
+		ctx.Logger().Error("Protorev error getting pool in AfterCFMMPoolCreated hook: " + err.Error())
 		return
 	}
 
 	denoms, err := k.poolmanagerKeeper.RouteGetPoolDenoms(ctx, poolId)
 	if err != nil {
-		ctx.Logger().Error("Protorev error getting pool liquidity in afterPoolCreated", err)
+		ctx.Logger().Error("Protorev error getting pool liquidity in afterPoolCreated: " + err.Error())
 		return
 	}
 
@@ -204,14 +204,14 @@ func (k Keeper) CompareAndStorePool(ctx sdk.Context, poolId uint64, baseDenom, o
 	// Get comparable liquidity for the new pool
 	newPoolLiquidity, err := k.GetComparablePoolLiquidity(ctx, poolId)
 	if err != nil {
-		ctx.Logger().Error("Protorev error getting newPoolLiquidity in compareAndStorePool", err)
+		ctx.Logger().Error("Protorev error getting newPoolLiquidity in compareAndStorePool: " + err.Error())
 		return
 	}
 
 	// Get comparable liquidity for the stored pool
 	storedPoolLiquidity, err := k.GetComparablePoolLiquidity(ctx, storedPoolId)
 	if err != nil {
-		ctx.Logger().Error("Protorev error getting storedPoolLiquidity in compareAndStorePool", err)
+		ctx.Logger().Error("Protorev error getting storedPoolLiquidity in compareAndStorePool: " + err.Error())
 		return
 	}
 

diff --git a/x/protorev/keeper/posthandler.go b/x/protorev/keeper/posthandler.go
@@ -58,7 +58,7 @@ func (protoRevDec ProtoRevDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simu
 		write()
 		ctx.EventManager().EmitEvents(cacheCtx.EventManager().Events())
 	} else {
-		ctx.Logger().Error("ProtoRevTrade failed with error", err)
+		ctx.Logger().Error("ProtoRevTrade failed with error: " + err.Error())
 	}
 
 	// Delete swaps to backrun for next transaction without consuming gas

diff --git a/x/protorev/keeper/rebalance.go b/x/protorev/keeper/rebalance.go
@@ -224,7 +224,7 @@ func (k Keeper) ExecuteTrade(ctx sdk.Context, route poolmanagertypes.SwapAmountI
 
 	// Send the developer fee to the developer address
 	if err := k.SendDeveloperFee(ctx, sdk.NewCoin(inputCoin.Denom, profit)); err != nil {
-		ctx.Logger().Error("failed to send developer fee", "error", err)
+		ctx.Logger().Error("failed to send developer fee: " + err.Error())
 	}
 
 	// Create and emit the backrun event and add it to the context