Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protorev: Properly log error #5862

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Protorev: Properly log error #5862

merged 1 commit into from
Jul 28, 2023

Conversation

NotJeremyLiu
Copy link
Contributor

@NotJeremyLiu NotJeremyLiu commented Jul 18, 2023 •
edited
Loading

What is the purpose of the change

  • This PR fixes places in the ProtoRev module that did not log passed up errors properly.

Testing and Verifying

  • Verified on LocalOsmosis

Documentation and Release Note

N/a

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@NotJeremyLiu NotJeremyLiu mentioned this pull request Jul 18, 2023
Closed
10 tasks
@NotJeremyLiu NotJeremyLiu added A:no-changelog V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jul 18, 2023
@NotJeremyLiu NotJeremyLiu force-pushed the jl/fix-protorev-error-logging branch from d8e98a4 to 311de92 Compare July 27, 2023 23:00
@NotJeremyLiu NotJeremyLiu marked this pull request as ready for review July 27, 2023 23:04
@NotJeremyLiu NotJeremyLiu requested a review from p0mvn as a code owner July 27, 2023 23:04
@NotJeremyLiu NotJeremyLiu requested a review from stackman27 July 27, 2023 23:12
@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v16.x backport patches to v16.x branch and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jul 28, 2023
@ValarDragon ValarDragon merged commit 8275750 into main Jul 28, 2023
@ValarDragon ValarDragon deleted the jl/fix-protorev-error-logging branch July 28, 2023 16:01
mergify bot pushed a commit that referenced this pull request Jul 28, 2023
@NotJeremyLiu @mergify
Properly log error (#5862)
010ad66 
(cherry picked from commit 8275750)
@mergify mergify bot mentioned this pull request Jul 28, 2023
Merged
ValarDragon pushed a commit that referenced this pull request Jul 28, 2023
@mergify @NotJeremyLiu
Properly log error (#5862) (#5912)
3a9e8e7 
(cherry picked from commit 8275750)

Co-authored-by: Jeremy Liu <[email protected]>
VitalyV1337 pushed a commit to VitalyV1337/osmosis-1 that referenced this pull request Jul 31, 2023
@NotJeremyLiu @VitalyV1337
Properly log error (osmosis-labs#5862)
aad5c87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

@p0mvn p0mvn Awaiting requested review from p0mvn p0mvn is a code owner

@stackman27 stackman27 Awaiting requested review from stackman27

Assignees
No one assigned
Labels
A:backport/v16.x backport patches to v16.x branch A:no-changelog V:state/compatible/backport State machine compatible PR, should be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NotJeremyLiu @ValarDragon