Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port package names in CMake to gz #220

Merged
merged 3 commits into from
Jun 28, 2022
Merged

Conversation

adityapande-1995
Copy link
Collaborator

Signed-off-by: Aditya [email protected]

This makes the find_package() and linking macros use the gz prefixed package names.

@adityapande-1995
Copy link
Collaborator Author

Locally, the build process crashes due to Eigen :

Starting >>> lrauv_description
Starting >>> lrauv_ignition_plugins
Finished <<< lrauv_description [0.77s]
--- stderr: lrauv_ignition_plugins
** WARNING ** io features related to openni will be disabled
** WARNING ** io features related to openni2 will be disabled
** WARNING ** io features related to pcap will be disabled
** WARNING ** io features related to png will be disabled
** WARNING ** io features related to libusb-1.0 will be disabled
** WARNING ** visualization features related to openni will be disabled
** WARNING ** visualization features related to openni2 will be disabled
** WARNING ** apps features related to openni will be disabled
/home/developer/lrauv_ws/src/lrauv/lrauv_ignition_plugins/src/HydrodynamicsPlugin.cc:25:10: fatal error: Eigen/Eigen: No such file or directory
 #include <Eigen/Eigen>
          ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/HydrodynamicsPlugin.dir/build.make:63: CMakeFiles/HydrodynamicsPlugin.dir/src/HydrodynamicsPlugin.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:618: CMakeFiles/HydrodynamicsPlugin.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:141: all] Error 2
---
Failed   <<< lrauv_ignition_plugins [13.0s, exited with code 2]

and the CI is failing to due apt install somehow (?) looking into it.

@playertr
Copy link
Collaborator

I got the same Eigen error as you, @adityapande-1995 . I followed this advice to symlink Eigen to eigen3, but it seems hacky.

Signed-off-by: Aditya <[email protected]>
@adityapande-1995
Copy link
Collaborator Author

adityapande-1995 commented Jun 27, 2022

I am able to build just this lrauv repo locally now (excluding lrauv-app) , with a garden installation from source and a sudo apt-get install python3-ignition-math7

@adityapande-1995 adityapande-1995 mentioned this pull request Jun 27, 2022
15 tasks
Copy link
Collaborator

@playertr playertr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me, and I was able to build against Ben's PR in lrauv-application.

I guess the next step might be to move from lrauv_ignition_plugins to lrauv_gz_plugins eventually, but that's outside the scope of this PR.

@braanan braanan self-requested a review June 28, 2022 00:56
@braanan
Copy link
Collaborator

braanan commented Jun 28, 2022

Works for me. Unless @hidmic has further comments, let's get this PR merged and I'll rebuild the docker image for CI with the lrauv-app changes

Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments, let's get this in!

@adityapande-1995 adityapande-1995 merged commit 78a4f17 into main Jun 28, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/port_package_names branch June 28, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants