-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port package names in CMake to gz #220
Conversation
Signed-off-by: Aditya <[email protected]>
Locally, the build process crashes due to Eigen :
and the CI is failing to due |
I got the same Eigen error as you, @adityapande-1995 . I followed this advice to symlink Eigen to eigen3, but it seems hacky. |
Signed-off-by: Aditya <[email protected]>
I am able to build just this lrauv repo locally now (excluding lrauv-app) , with a garden installation from source and a |
Signed-off-by: Aditya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, and I was able to build against Ben's PR in lrauv-application.
I guess the next step might be to move from lrauv_ignition_plugins to lrauv_gz_plugins eventually, but that's outside the scope of this PR.
Works for me. Unless @hidmic has further comments, let's get this PR merged and I'll rebuild the docker image for CI with the lrauv-app changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No comments, let's get this in!
Signed-off-by: Aditya [email protected]
This makes the
find_package()
and linking macros use thegz
prefixed package names.