Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acoustic comms refactoring #232

Merged
merged 13 commits into from
Aug 31, 2022
Merged

Acoustic comms refactoring #232

merged 13 commits into from
Aug 31, 2022

Conversation

adityapande-1995
Copy link
Collaborator

@adityapande-1995 adityapande-1995 commented Aug 3, 2022 •
edited
Loading

This PR attempts to use the upstream acoustic comms plugin (gazebosim/gz-sim#1608) in gz-sim, and replace the implementation here.

@adityapande-1995 adityapande-1995 marked this pull request as ready for review August 6, 2022 00:53
@adityapande-1995
Copy link
Collaborator Author

The failing tests are also failing on main. The only thing left here is removing the old AcousticComms.h/cc files and its remnants from CMakeLists.txt

arjo129
arjo129 reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me. We just need to make the tests pass.

lrauv_system_tests/test/simulation/test_spawn.cc Outdated Show resolved Hide resolved
@adityapande-1995 adityapande-1995 mentioned this pull request Aug 23, 2022
Closed
@adityapande-1995 adityapande-1995 mentioned this pull request Aug 26, 2022
Closed
@adityapande-1995 adityapande-1995 marked this pull request as draft August 26, 2022 09:48
@adityapande-1995 adityapande-1995 marked this pull request as ready for review August 26, 2022 19:28
@adityapande-1995
Copy link
Collaborator Author

adityapande-1995 commented Aug 26, 2022 •
edited
Loading

@arjo129 , we have CI passing here ! Are the changes here compatible with LRAUV app ? i.e. I'm trying to understand how Acoustic comms used to interact with the app. Is the CI testing against the app here @hidmic ? AFA I see, the app does not contain any acoustic message interaction, so we should be safe.

Note : Old acoustic comms message, CommsClient are not to be removed, as the comms client is now just wrapping over the old message.

@adityapande-1995 adityapande-1995 merged commit b448dee into main Aug 31, 2022
@adityapande-1995 adityapande-1995 deleted the aditya/acoustic_comms_refactor branch August 31, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hidmic hidmic hidmic approved these changes

@arjo129 arjo129 Awaiting requested review from arjo129

@caguero caguero Awaiting requested review from caguero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityapande-1995 @arjo129 @hidmic