Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #48
buoyancyAction
andbuoyancyPosition
. Looking at the code history, it looks like at some point cc (cubic centimeter) was used as a unit, but AFAICT, both our plugins and the controller are consistently using cubic meters, so I documented this.LRAUV_example_buoyancy
more flexible so we can test different volumes.test_buoyancy_action
has correct expectationsbuoyancy_engine
link, becuase I believe we have a different issue now.It would be good to have some eyes on this PR by people who have been involved in the original implementation (@mabelzhang / @arjo129 ), just to make sure I didn't miss anything related to units and the inertial TODO.