Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@overcat, appreciate all your work on this!
As you'll see here, I've refactored your display code to leverage our existing GUI components and constants wherever possible. The
TextArea
in particular has important additional features: it super-samples small text to render them with much better anti-aliasing which greatly aids in readability.And then when specifying x,y coords or sizes, as much as possible, it's better to use a relative approach rather than absolute, hard-coded values.
So rather than something like:
it's better to do:
I also made a number of adjustments (e.g. font, spacing) to remain consistent with @easyuxd's UI principles.
I also tweaked the duration timing to be just a little bit longer.
If you merge this PR into your branch, your PR in the main SeedSigner repo will automatically be updated with these changes.