Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring PR #389 #1

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Conversation

kdmukai
Copy link

@kdmukai kdmukai commented Jul 15, 2023

@overcat, appreciate all your work on this!

As you'll see here, I've refactored your display code to leverage our existing GUI components and constants wherever possible. The TextArea in particular has important additional features: it super-samples small text to render them with much better anti-aliasing which greatly aids in readability.

And then when specifying x,y coords or sizes, as much as possible, it's better to use a relative approach rather than absolute, hard-coded values.

So rather than something like:

y1 = 50
y2 = 125

it's better to do:

y1 = SOME_INITIAL_SPACER
y2 = y1 + element1.height + SOME_COMPONENT_SPACER

I also made a number of adjustments (e.g. font, spacing) to remain consistent with @easyuxd's UI principles.


I also tweaked the duration timing to be just a little bit longer.


If you merge this PR into your branch, your PR in the main SeedSigner repo will automatically be updated with these changes.

@overcat overcat merged commit ef70a8d into overcat:qr-brightness-tips Jul 15, 2023
@kdmukai kdmukai deleted the pr_389_kdmukai branch September 2, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants