Removes appframework dependancy from 3rdparty. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BernhardPosselt I have given you credit on the angular directive here, though. Its the only part of appframework.js we are using. |
| License along with this library. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| app.directive('ocClickSlideToggle', [ |
There was a problem hiding this comment.
IIRC this is more or less in core now ;)
See data-apps-slide-toggle: https://doc.owncloud.org/server/8.1/developer_manual/app/css.html#settings-area
There was a problem hiding this comment.
Awesome. I will check this asap and remove the directive if required.
There was a problem hiding this comment.
@raghunayyar Did you check yet?
raghunayyar
force-pushed
the
remove-appframeworkjs
branch
from
d0581df to
1e66362
Compare
|
Updated as per @BernhardPosselt's call. This is awesome. @georgehrke please check and 👍 |
|
👍 |
georgehrke
added a commit
that referenced
this pull request
Oct 29, 2015
Removes appframework dependancy from 3rdparty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Appframework dependency from 3rdparty.
@georgehrke lets get this one in. :D