Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Win] Remove legacy setting for sidebar entries #10788

Closed
michaelstingl opened this issue May 2, 2023 · 1 comment · Fixed by #10910
Closed

[Win] Remove legacy setting for sidebar entries #10788

michaelstingl opened this issue May 2, 2023 · 1 comment · Fixed by #10910
Assignees
@erikjv
Labels
p4-low Low priority
Milestone
Desktop 5.0

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented May 2, 2023 •
edited by TheOneRing
Loading

https://central.owncloud.org/t/synced-folders-still-show-in-win10-explorer-pane-despite-unchecking-show-option-in-owncloud-client/42096

@TheOneRing @HanaGemela 4.x or 5.0 ?

The setting has no effect on windows vfs, its only relevant for vfs off mode.
As Windows vfs is the default, we decided to remove the legacy setting which is confusing to the user.
This means with vfs off we will always create a sidebar entry.
image
@michaelstingl michaelstingl added this to the Desktop Client 5.0 milestone May 9, 2023
@michaelstingl michaelstingl added the p4-low Low priority label May 9, 2023
erikjv added a commit that referenced this issue Jun 5, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
b3fc306 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
@erikjv erikjv mentioned this issue Jun 5, 2023
Merged
erikjv added a commit that referenced this issue Jun 6, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
b3ffdeb 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
erikjv added a commit that referenced this issue Jun 26, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
e0c5e75 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
erikjv added a commit that referenced this issue Jun 26, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
c3f3920 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
erikjv added a commit that referenced this issue Jul 3, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
5e6dea1 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
erikjv added a commit that referenced this issue Jul 3, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
ced60e1 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
erikjv added a commit that referenced this issue Jul 4, 2023
@erikjv
[Win] Remove legacy setting for sidebar entries
44e95fa 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
TheOneRing pushed a commit that referenced this issue Jul 4, 2023
@erikjv @TheOneRing
[Win] Remove legacy setting for sidebar entries
6856695 
We get this for free from the CfApi, and enabling this with winvfs
results in duplicate entries.

Fixes: #10788
@saw-jan
Copy link
Member

saw-jan commented Jul 5, 2023

Tested with ownCloud 5.0.0.11384-daily20230705 1c0613 on win10

Screenshot from 2023-07-05 11-24-44

@michaelstingl michaelstingl mentioned this issue Nov 7, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
p4-low Low priority
Projects
None yet
Milestone
Desktop 5.0
Development

Successfully merging a pull request may close this issue.

[Win] Remove legacy setting for sidebar entries owncloud/client
3 participants
@erikjv @michaelstingl @saw-jan