Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] [HiDPi] Overlay-Icons of Desktop Client / Gray Border #3105

Closed
realdognose opened this issue Apr 12, 2015 · 4 comments
Closed

[Windows] [HiDPi] Overlay-Icons of Desktop Client / Gray Border #3105

realdognose opened this issue Apr 12, 2015 · 4 comments
Assignees
@jturcotte
Labels
Design & UX sev3-medium type:bug
Milestone
2.1.1-current

Comments

@realdognose
Copy link

The "Green-Tick-Icon" of the Desktop-Client seems to have a grayish border around it. (1.8.0 build 4893)

See Screenshot:

image

Nothing Critical, just grinds my gears everytime I see it :)

Maybe it's worth mentioning that i'm using 4k Resolution with a 200% UI-Scale. Maybe the border just appears due to upscaling of the icon.

Edit: Yes seems to be a 4k-Issue. On my Notebook the Icon looks way larger and no border is visible.
@realdognose realdognose mentioned this issue Apr 12, 2015
Closed
@guruz guruz added the type:bug label Apr 13, 2015
@guruz guruz added this to the 1.9 - Multi-account milestone Apr 13, 2015
@guruz
Copy link
Contributor

guruz commented Apr 13, 2015

This is using which Windows version? :)

@realdognose
Copy link
Author

Windows 8.1 64bit

@danimo
Copy link
Contributor

danimo commented Apr 14, 2015

Probably related to us not providing a hi-res icon (128px), because the png2ico tool cannot deal with that.

@MTRichards MTRichards modified the milestones: 2.1-next, 2.0 - Multi-account Jun 19, 2015
@guruz guruz changed the title Status-Icons of Desktop Client / Gray Border [Windows] Overlay-Icons of Desktop Client / Gray Border Aug 31, 2015
@guruz guruz modified the milestones: 2.1.2, 2.1-next Nov 3, 2015
@guruz guruz unassigned danimo Nov 3, 2015
@guruz guruz changed the title [Windows] Overlay-Icons of Desktop Client / Gray Border [Windows] [HiDPi] Overlay-Icons of Desktop Client / Gray Border Jan 5, 2016
jturcotte added a commit that referenced this issue Jan 12, 2016
@jturcotte
Windows: Update the overlay icon graphics #3105
bb5c370 
The bug seems to be in Windows when it upscales an smaller icon for
HiDPI displays. It works fine if we provide a 256x256 size in the
ico files.

Use the new square icons also used on OS X that removes the share badge
and instead has a share icon only for the OK state. This means that we
can also remove 3 icons and release 3 slots in the registry for
overlay icons (only the first few are actually loaded by explorer).

This also adds a script that uses ImageMagick to convert our SVG icons
to Windows ico files. Since ImageMagick seems to have issue doing
proper antialiasing with pixels on the edge of icons, this also
slightly scale the icons to leave 2px on each edge, out of its
logical 128px width.
@jturcotte jturcotte added the ReadyToTest QA, please validate the fix/enhancement label Jan 12, 2016
@Dianafg76 Dianafg76 removed the ReadyToTest QA, please validate the fix/enhancement label Jan 20, 2016
@Dianafg76
Copy link

I tested this issue and is working ok
Desktop v 2.1.1 beta1 (build 5780)
Server v 8.2.2

@SamuAlfageme SamuAlfageme mentioned this issue Oct 16, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jturcotte jturcotte

Labels
Design & UX sev3-medium type:bug
Projects
None yet
Milestone
2.1.1-current
Development

No branches or pull requests
6 participants
@jturcotte @guruz @danimo @MTRichards @realdognose @Dianafg76