[Overlays][Linux Shell Extensions] Change Overlay Icon Size in Nautilus

[voroyam]

Can one tell owncloud / nautilus to use bigger overlay icons for files?

[meithan]

I think the root of the issue is that OC makes the actual overlay icons smaller to reserve space for the "shared" icon.

Here's how the 32x32 "OK" overlay icon (located at /usr/share/icons/hicolor/32x32/apps/ownCloud_ok.png on my Linux install) looks like:

https://i.imgur.com/DzoyCcK.png

The image bounding box is indeed 32x32, but the actual icon is less than half that size. I think the reason this is done is to reserve space for the "shared" icon:

https://i.imgur.com/FRskQ2a.png

(located at /usr/share/icons/hicolor/32x32/apps/ownCloud_ok_shared.png)

A solution could be to modify the icons so that the OK icon normally fills its bounding box and only make it smaller when the shared icon is also needed (or perhaps the shared icon could be placed in the corner on top of the full-size OK icon, or something like that).

[SamuAlfageme]

This was reported & fixed in windows in #3105 (with the set of icons also used for macOS)

We should remove a lot of legacy overlay content from /shell_integration/icons I feel like there's lots of duplicated stuff in there.

[guruz]

Maybe @voroyam could try the alpha?
https://owncloud.org/changelog/desktop/

EDIT: Ok ignore that, maybe nothing changed in the new version

[meithan]

@SamuAlfageme: wasn't #3105 about the gray border around the icons? Anyway that issue was closed on Jan 2016 with a fix in v2.1.1, but the "issue" i'm reporting is happening on v2.3.3, so it's not really fixed.

[meithan]

I finally got around to test resized icons, and they seem to work alright (unsurprisingly):

So I guess it's just a matter of redoing the icon set? Assuming other people feel that the larger icons looks better. I'm not even sure myself. This full-size icon I made does seem a bit obnoxious. Perhaps 75% size?

Edit: Here, I resized the icon to 75% size and I think I'm liking it:

[SamuAlfageme]

@meithan

wasn't #3105 about the gray border around the icons?

As you mentioned in #6094 (comment) it was because:

the reason this is done is to reserve space for the "shared" icon

And about #3105 being closed, yup: the scope of that fix was only Windows. While it's still affecting Linux shell integrations (or at least Nautilus).

The non-padded set is located in https://github.com/owncloud/client/tree/master/shell_integration/icons/nopadding. Thanks a bunch for testing it out with the resized icons!

[meithan]

Thanks for pointing me to these icons, @SamuAlfageme, I (shamefully) did not think of browsing through the repo to see what icons were available. I see there's svg originals too! I'm going to test some options with icons generated from the svg's. I think I'm liking how the 75% size ones look.

Reading the commit message for #3105 I now understand why you brought it up. The only problem for Linux will be that it uses more icons than the Windows or Mac clients (those removed the "share badges", and only show a share icon for the OK state), so the non-padded icon set doesn't have all the required icons. We could either make new icons from the svg's, or tweak the nautilus shell integration plugin to use the reduced icon set, which I understand would be accomplished by modifying syncstate.py. From a quick glance I think tweaking this function might be enough for a dirty fix, but the correct way is to get rid of those other states in the logic.

[voroyam]

@michaelstingl I would like to close this.

opened in 2017, now is 2021, no progress.

[TheOneRing]

Is this actually still an issue with the new svg icons we ship since 2.7?

[voroyam]

apparently not, otherwise we would have gotten some feedback from users.

[TheOneRing]

@gabi18 can you have a look?

[voroyam]

any updates? @TheOneRing