-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash in DiscoveryPhase::findAndCancelDeletedJob #7722
Comments
Next steps: Patch release if needed, stop auto updater if needed, stop branded release if needed |
HanaGemela
added
type:bug
p2-high
Escalation, on top of current planning, release blocker
labels
Feb 6, 2020
ogoffart
added a commit
that referenced
this issue
Feb 6, 2020
This was an attempt to reproduce #7722, but this actually does not reproduce it
ogoffart
added a commit
that referenced
this issue
Feb 6, 2020
…edJob Issue #7722 I was not able to reproduce the crash, but this is seen in the crash reporter. The crash occurs because the ENFORCE in that function is reached. One way this could happen is because findAndCancelDeletedJob would be called for the same path multiple times. Potentially this could perhaps be caused by duplicated inodes are duplicated. But this is hard to test.
ogoffart
added a commit
that referenced
this issue
Feb 10, 2020
This was an attempt to reproduce #7722, but this actually does not reproduce it
ogoffart
added a commit
that referenced
this issue
Feb 10, 2020
…edJob Issue #7722 I was not able to reproduce the crash, but this is seen in the crash reporter. The crash occurs because the ENFORCE in that function is reached. One way this could happen is because findAndCancelDeletedJob would be called for the same path multiple times. Potentially this could perhaps be caused by duplicated inodes are duplicated. But this is hard to test.
should be fixed – reopen if we see still see issues in 2.6.2… |
47 tasks
Closed
@ogoffart please provide steps to test if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://sentry.io/organizations/owncloud/issues/1486987547/?project=79001&sort=new
the problem is that the enforce there is triggered:
client/src/libsync/discoveryphase.cpp
Lines 162 to 166 in 1a7fc71
Looks like we should remove the item from the deleted list there.
I don't know how this can be reproduced in a test
The text was updated successfully, but these errors were encountered: