Fix a potential crash in moves #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an attempt to reproduce #7722, but this actually does not reproduce it
…edJob Issue #7722 I was not able to reproduce the crash, but this is seen in the crash reporter. The crash occurs because the ENFORCE in that function is reached. One way this could happen is because findAndCancelDeletedJob would be called for the same path multiple times. Potentially this could perhaps be caused by duplicated inodes are duplicated. But this is hard to test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7722
I was not able to reproduce the problem (the new tests don't reproduce it)
But this is just the most plausible explanation for this crash.