Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening the browser #10387

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix opening the browser #10387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/10387
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Open in web if debug logs are turned off

Due to a bug opening the browser only worked if logging was enabled.

https://github.com/owncloud/client/pull/10387
3 changes: 2 additions & 1 deletion src/libsync/appprovider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ bool AppProvider::open(const AccountPtr &account, const QString &localPath, cons
QObject::connect(job, &JsonJob::finishedSignal, [job, localPath] {
if (job->httpStatusCode() == 200) {
const auto url = QUrl(job->data().value(QStringLiteral("uri")).toString());
qCDebug(lcAppProvider) << "start browser" << url << QDesktopServices::openUrl(url);
const auto result = QDesktopServices::openUrl(url);
qCDebug(lcAppProvider) << "start browser" << url << result;
} else {
QMetaObject::invokeMethod(qApp, "slotShowGuiMessage", Qt::QueuedConnection,
Q_ARG(QString, QCoreApplication::translate("AppProvider", "Error")),
Expand Down