Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opening the browser #10387

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Fix opening the browser #10387

merged 1 commit into from
Jan 10, 2023

Conversation

TheOneRing
Copy link
Contributor

Due to a bug opening in browser only worked when logs where active

@TheOneRing TheOneRing requested a review from a team January 4, 2023 10:30
@TheOneRing
Fix opening the browser
01fc810 
Due to a bug opening in browser only worked when logs where active
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Jan 4, 2023
@TheOneRing TheOneRing added this to the 3.1 milestone Jan 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit 15ae46d into 3.1 Jan 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the work/fix_open_web branch January 10, 2023 13:40
@TheOneRing
Copy link
Contributor Author

Testing:

  • 3.0 Disable logs (start the client without --logfile and disable logging in the settings), connect to a Koko server, right click a .odt, open in web... nothing will happen.
  • With logs enabled the browser opens.
  • 3.1 Independent of logging the browser will open.

@HanaGemela HanaGemela self-assigned this Jan 13, 2023
@HanaGemela
Copy link
Contributor

Passed in ownCloud 3.1.0.9748-daily20230113 mac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

Assignees

@HanaGemela HanaGemela

Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOneRing @HanaGemela @fmoc