Make ownCloud work again in php 7.0.6 #24326
Conversation
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @DeepDiver1975 and @Xenopathic to be potential reviewers |
| @@ -271,6 +271,9 @@ public function __get($name) { | |||
| * @return bool | |||
| */ | |||
| public function __isset($name) { | |||
| if (in_array($name, $this->allowedKeys, true)) { | |||
There was a problem hiding this comment.
This worked for me. Pulled a PHP 7 update from Ubuntu's official update repo's and my ownCloud broke down. Thanks to all who came up with a patch!
There was a problem hiding this comment.
@thomasvnl You don't need this patch. Just use the current oC version 9.0.4 which already includes this.
There was a problem hiding this comment.
@RealRancor I understand, but yesterday I didn't have time to update my ownCloud from 9.0.0 to 9.0.4. I also noticed the fix isn't mentioned in the changelog, or am I mistaken? I've searched through the changelog first before taking this route.
Thanks for notifying me about the fix being included in 9.0.4.
There was a problem hiding this comment.
From what I see the fix was already in 9.0.2 #24343
There was a problem hiding this comment.
Yes, and also listed in the (quite large) ChangeLog of 9.0.2:
[Stable 9] Make ownCloud work again in php 7.0.6 - #24343
There was a problem hiding this comment.
@PVince81 @RealRancor totally missed it! Thanks guys.
|
Is Jenkins using PHP 7.0.6? |
|
Because Travis isn't: |
PHP 7.0.6 is not even officially announced: |
|
@RealRancor - Of course, but what I'm saying is that we can't be almost absolutely certain that this is the only required change unless the branch uses PHP 7.0.6 for tests. |
|
I ran the unit test locally with php 7.0.6 (which is tagged alrady) and now they pass. |
|
And at least we know it is not breaking older isntances. |
|
As an Arch Linux user, I updated to PHP 7.0.6, too, as it was available on the package mirrors during the update I made today. This patch does indeed work and I can use ownCloud on my server again 👍 |
ghost
mentioned this pull request
|
I'm also an Arch Linux user and I updated to PHP 7.0.6. This PR fixes the issue. 👍 |
|
@karlitschek we should backport this. Else users on stable 8.2 and 9.0 might run into trouble if they run bleeding edge php |
ghost
mentioned this pull request
|
backport makes sense 👍 |
|
Just spent about two hours debugging why owncloud stopped working. Find out that my webhost upgraded to PHP 7.0.6. Fix mentioned above did the trick. |
|
this patch worked for me, too! |
|
Thank you for the patch. I was able to fix up my installation as well! 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
See https://bugs.php.net/bug.php?id=72117
CC: @nickvergessen @PVince81 @LukasReschke @DeepDiver1975