Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ownCloud work again in php 7.0.6 #24326

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Make ownCloud work again in php 7.0.6 #24326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/private/AppFramework/Http/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ public function __get($name) {
* @return bool
*/
public function __isset($name) {
if (in_array($name, $this->allowedKeys, true)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use hasMember?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how?

Copy link

@thomasvnl thomasvnl Jul 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked for me. Pulled a PHP 7 update from Ubuntu's official update repo's and my ownCloud broke down. Thanks to all who came up with a patch!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasvnl You don't need this patch. Just use the current oC version 9.0.4 which already includes this.

Copy link

@thomasvnl thomasvnl Jul 21, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RealRancor I understand, but yesterday I didn't have time to update my ownCloud from 9.0.0 to 9.0.4. I also noticed the fix isn't mentioned in the changelog, or am I mistaken? I've searched through the changelog first before taking this route.

Thanks for notifying me about the fix being included in 9.0.4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I see the fix was already in 9.0.2 #24343

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and also listed in the (quite large) ChangeLog of 9.0.2:

[Stable 9] Make ownCloud work again in php 7.0.6 - #24343

https://owncloud.org/changelog/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81 @RealRancor totally missed it! Thanks guys.

return true;
}
return isset($this->items['parameters'][$name]);
}

Expand Down