Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] skip tests for async file operations in ocis #38914

Merged
merged 1 commit into from
Jun 30, 2021
Merged

[Tests-Only] skip tests for async file operations in ocis #38914

merged 1 commit into from
Jun 30, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 30, 2021 •
edited
Loading

Description

skip tests for async file operations in ocis as they wont be implemented there.
owncloud/ocis#1790 (comment)

Skip default blacklisted filename (".htaccess") test in ocis since it can be uploaded in ocis

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach dpakach requested review from jasson99 and phil-davis June 30, 2021 08:54
@dpakach dpakach self-assigned this Jun 30, 2021
@dpakach dpakach force-pushed the skip-async-tests branch from b09e9c5 to 2e4281e Compare June 30, 2021 10:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dpakach dpakach requested a review from kiranparajuli589 June 30, 2021 12:34
@phil-davis phil-davis merged commit 008fe2f into master Jun 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the skip-async-tests branch June 30, 2021 15:42
@dpakach dpakach mentioned this pull request Jul 1, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@dpakach dpakach

Labels
3 - To Review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpakach @phil-davis