Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] skip tests for async file move operations #38927

Merged
merged 1 commit into from
Jul 1, 2021
Merged

[Tests-Only] skip tests for async file move operations #38927

merged 1 commit into from
Jul 1, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jul 1, 2021 •
edited
Loading

Description

One file was missed in #38914 to add skipOnocis tag.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@dpakach dpakach requested review from jasson99, Talank and phil-davis July 1, 2021 08:08
@dpakach dpakach self-assigned this Jul 1, 2021
@dpakach dpakach marked this pull request as ready for review July 1, 2021 08:09
Talank
Talank reviewed Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit b1efa3b into master Jul 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the skip-async-move-tests branch July 1, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@phil-davis phil-davis phil-davis approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

Assignees

@dpakach dpakach

Labels
dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpakach @phil-davis @Talank