Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] adds @notToImplementOnOCIS tag for subadmin scenarios #39122

Merged
merged 1 commit into from
Aug 19, 2021
Merged

[tests-only] [full-ci] adds @notToImplementOnOCIS tag for subadmin scenarios #39122

merged 1 commit into from
Aug 19, 2021

Conversation

sakshamgurung
Copy link
Contributor

@sakshamgurung sakshamgurung commented Aug 18, 2021 •
edited
Loading

Description

  • Adds @notToImplementOnOCIS tag for subadmin scenarios in following folders:
  • apiProvisioning-v1
  • apiProvisioning-v2
  • apiProvisioningGroups-v1
  • apiProvisioningGroups-v2
  • check other feature file for "subadmin"

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sakshamgurung sakshamgurung force-pushed the subadmin-related-notToImplementOnOcis branch 2 times, most recently from 0088c66 to f73068f Compare August 19, 2021 05:40
@sakshamgurung sakshamgurung marked this pull request as ready for review August 19, 2021 05:41
phil-davis
phil-davis reviewed Aug 19, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the notToImplementOnOCIS tags from those scenarios. That will make this PR clearly only about subadmin scenarios.

Then it is another question about if some other provisioning API features should be usable by ordinary users.

tests/acceptance/features/apiProvisioningGroups-v1/addToGroup.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiProvisioningGroups-v1/getUserGroups.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiProvisioningGroups-v2/getUserGroups.feature Outdated Show resolved Hide resolved
@sakshamgurung sakshamgurung force-pushed the subadmin-related-notToImplementOnOcis branch from f73068f to a8c434e Compare August 19, 2021 06:58
@phil-davis phil-davis self-requested a review August 19, 2021 07:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 5f01135 into owncloud:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@swoichha swoichha Awaiting requested review from swoichha

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@sakshamgurung sakshamgurung

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakshamgurung @phil-davis @SwikritiT