Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] adds @notToImplementOnOCIS tag for subadmin scenarios #39122

Merged
merged 1 commit into from
Aug 19, 2021
Merged

[tests-only] [full-ci] adds @notToImplementOnOCIS tag for subadmin scenarios #39122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/acceptance/features/apiProvisioning-v1/addUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Feature: add user
| 123 |
| -123 |
| 0.0 |

@notToImplementOnOCIS
Scenario: subadmin should not be able to create a new user
Given user "brand-new-user" has been deleted
And user "subadmin" has been created with default attributes and without skeleton files
Expand All @@ -174,7 +174,7 @@ Feature: add user
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "brand-new-user" should not exist

@notToImplementOnOCIS
Scenario: subadmin should be able to create a new user into their group
Given user "brand-new-user" has been deleted
And user "subadmin" has been created with default attributes and without skeleton files
Expand All @@ -185,7 +185,7 @@ Feature: add user
Then the OCS status code should be "100"
And the HTTP status code should be "200"
And user "brand-new-user" should exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to create a new user into other group
Given user "brand-new-user" has been deleted
And user "subadmin" has been created with default attributes and without skeleton files
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/apiProvisioning-v1/createSubAdmin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @provisioning_api-app-required @skipOnLDAP
@api @provisioning_api-app-required @skipOnLDAP @notToImplementOnOCIS
Feature: create a subadmin
As an admin
I want to be able to make a user the subadmin of a group
Expand Down Expand Up @@ -47,9 +47,9 @@ Feature: create a subadmin

Scenario: normal user should not be able to make another user a subadmin
Given these users have been created with default attributes and without skeleton files:
| username |
| Alice |
| Brian |
| username |
| Alice |
| Brian |
And group "group101" has been created
When user "Alice" makes user "Brian" a subadmin of group "group101" using the provisioning API
Then the OCS status code should be "997"
Expand Down
18 changes: 9 additions & 9 deletions tests/acceptance/features/apiProvisioning-v1/deleteUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,14 @@ Feature: delete users

Scenario: administrator deletes another admin user
Given these users have been created with default attributes and without skeleton files:
| username |
| another-admin |
| username |
| another-admin |
And user "another-admin" has been added to group "admin"
When the administrator deletes user "another-admin" using the provisioning API
Then the OCS status code should be "100"
And the HTTP status code should be "200"
And user "another-admin" should not exist

@notToImplementOnOCIS
Scenario: subadmin deletes a user with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -86,7 +86,7 @@ Feature: delete users
Then the OCS status code should be "100"
And the HTTP status code should be "200"
And user "another-subadmin" should not exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to delete another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -99,12 +99,12 @@ Feature: delete users
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "another-subadmin" should exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to delete a user with admin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
| subadmin |
| another-admin |
| username |
| subadmin |
| another-admin |
And user "another-admin" has been added to group "admin"
And group "new-group" has been created
And user "another-admin" has been added to group "new-group"
Expand All @@ -113,7 +113,7 @@ Feature: delete users
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "another-admin" should exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to delete a user not in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiProvisioning-v1/disableUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ Feature: disable user
| old |
| new |


@notToImplementOnOCIS
Scenario: Subadmin should be able to disable user with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -271,7 +271,7 @@ Feature: disable user
And the HTTP status code should be "200"
And user "another-subadmin" should be disabled


@notToImplementOnOCIS
Scenario: Subadmin should not be able to disable another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/features/apiProvisioning-v1/editUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Feature: edit users
And the attributes of user "brand-new-user" returned by the API should include
| quota definition | default |
And the quota definition of user "brand-new-user" should be "default"

@notToImplementOnOCIS
Scenario: the administrator can edit user information with admin permissions
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -139,7 +139,7 @@ Feature: edit users
Then the display name of user "another-admin" should be "Anne Brown"
And the email address of user "another-admin" should be "[email protected]"
And the quota definition of user "another-admin" should be "12 MB"

@notToImplementOnOCIS
Scenario: a subadmin should be able to edit user information with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -155,7 +155,7 @@ Feature: edit users
Then the display name of user "another-subadmin" should be "Anne Brown"
And the email address of user "another-subadmin" should be "[email protected]"
And the quota definition of user "another-subadmin" should be "12 MB"

@notToImplementOnOCIS
Scenario: a subadmin should not be able to edit user information of another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiProvisioning-v1/getSubAdmins.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @provisioning_api-app-required @skipOnLDAP
@api @provisioning_api-app-required @skipOnLDAP @notToImplementOnOCIS
Feature: get subadmins
As an admin
I want to be able to get the list of subadmins of a group
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiProvisioning-v1/getUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Feature: get user
And the HTTP status code should be "200"
And the display name returned by the API should be "Admin Alice"
And the quota definition returned by the API should be "default"

@notToImplementOnOCIS
Scenario: a subadmin should be able to get information of a user with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -166,7 +166,7 @@ Feature: get user
And the HTTP status code should be "200"
And the display name returned by the API should be "Regular User"
And the quota definition returned by the API should be "default"

@notToImplementOnOCIS
Scenario: a subadmin should not be able to get information of another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/apiProvisioning-v1/resetUserPassword.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: reset user password
Then the OCS status code should be "997"
And the HTTP status code should be "401"

@smokeTest @skipOnEncryptionType:user-keys @encryption-issue-57 @toImplementOnOCIS
@smokeTest @skipOnEncryptionType:user-keys @encryption-issue-57 @notToImplementOnOCIS
Scenario: subadmin should be able to reset the password of a user in their group
Given these users have been created with small skeleton files:
| username | password | displayname | email |
Expand All @@ -39,7 +39,7 @@ Feature: reset user password
And the content of file "textfile0.txt" for user "brand-new-user" using password "%alt1%" should be "ownCloud test text file 0" plus end-of-line
But user "brand-new-user" using password "%regular%" should not be able to download file "textfile0.txt"

@toImplementOnOCIS
@notToImplementOnOCIS
Scenario: subadmin should not be able to reset the password of a user not in their group
Given these users have been created with small skeleton files:
| username | password | displayname | email |
Expand Down Expand Up @@ -109,7 +109,7 @@ Feature: reset user password
And the content of file "textfile0.txt" for user "Alice" using password "%alt1%" should be "ownCloud test text file 0" plus end-of-line
But user "Alice" using password "%regular%" should not be able to download file "textfile0.txt"

@skipOnEncryptionType:user-keys @encryption-issue-57
@skipOnEncryptionType:user-keys @encryption-issue-57 @notToImplementOnOCIS
Scenario: subadmin should be able to reset the password of a user with subadmin permissions in their group
Given these users have been created with small skeleton files:
| username | password | displayname | email |
Expand All @@ -125,7 +125,7 @@ Feature: reset user password
And the content of file "textfile0.txt" for user "brand-new-user" using password "%alt1%" should be "ownCloud test text file 0" plus end-of-line
But user "brand-new-user" using password "%regular%" should not be able to download file "textfile0.txt"


@notToImplementOnOCIS
Scenario: subadmin should not be able to reset the password of another subadmin of same group
Given these users have been created with small skeleton files:
| username | password | displayname | email |
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/features/apiProvisioning-v2/addUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ Feature: add user
| 123 |
| -123 |
| 0.0 |

@notToImplementOnOCIS
Scenario: subadmin should not be able to create a user
Given user "brand-new-user" has been deleted
And user "subadmin" has been created with default attributes and without skeleton files
Expand All @@ -174,7 +174,7 @@ Feature: add user
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "brand-new-user" should not exist

@notToImplementOnOCIS
Scenario: subadmin should be able to create a new user into their group
Given user "brand-new-user" has been deleted
And user "subadmin" has been created with default attributes and without skeleton files
Expand All @@ -185,7 +185,7 @@ Feature: add user
Then the OCS status code should be "200"
And the HTTP status code should be "200"
And user "brand-new-user" should exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to create a new user into other group
Given user "brand-new-user" has been deleted
And user "subadmin" has been created with default attributes and without skeleton files
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiProvisioning-v2/createSubAdmin.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @provisioning_api-app-required @skipOnLDAP
@api @provisioning_api-app-required @skipOnLDAP @notToImplementOnOCIS
Feature: create a subadmin
As an admin
I want to be able to make a user the subadmin of a group
Expand Down
10 changes: 5 additions & 5 deletions tests/acceptance/features/apiProvisioning-v2/deleteUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Feature: delete users
Then the OCS status code should be "401"
And the HTTP status code should be "401"
And user "Brian" should exist

@notToImplementOnOCIS
Scenario: administrator deletes another admin user
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -73,7 +73,7 @@ Feature: delete users
Then the OCS status code should be "200"
And the HTTP status code should be "200"
And user "another-admin" should not exist

@notToImplementOnOCIS
Scenario: subadmin deletes a user with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -87,7 +87,7 @@ Feature: delete users
Then the OCS status code should be "200"
And the HTTP status code should be "200"
And user "another-subadmin" should not exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to delete another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -100,7 +100,7 @@ Feature: delete users
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "another-subadmin" should exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to delete a user with admin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -114,7 +114,7 @@ Feature: delete users
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "another-admin" should exist

@notToImplementOnOCIS
Scenario: subadmin should not be able to delete a user not in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/apiProvisioning-v2/disableUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ Feature: disable user
And the HTTP status code should be "200"
And user "Alice" should be disabled

@issue-31276 @skipOnOcV10
@issue-31276 @skipOnOcV10 @notToImplementOnOCIS
Scenario: Subadmin should not be able to disable an user not in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -63,7 +63,7 @@ Feature: disable user
And the HTTP status code should be "401"
And user "Alice" should be enabled

@issue-31276 @skipOnOcV10
@issue-31276 @skipOnOcV10 @notToImplementOnOCIS
Scenario: Subadmins should not be able to disable users that have admin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down Expand Up @@ -253,7 +253,7 @@ Feature: disable user
| old |
| new |


@notToImplementOnOCIS
Scenario: Subadmin should be able to disable user with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -268,7 +268,7 @@ Feature: disable user
And the HTTP status code should be "200"
And user "another-subadmin" should be disabled


@notToImplementOnOCIS
Scenario: Subadmin should not be able to disable another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/features/apiProvisioning-v2/editUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ Feature: edit users
And the attributes of user "brand-new-user" returned by the API should include
| quota definition | default |
And the quota definition of user "brand-new-user" should be "default"

@notToImplementOnOCIS
Scenario: the administrator can edit user information with admin permissions
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -139,7 +139,7 @@ Feature: edit users
Then the display name of user "another-admin" should be "Anne Brown"
And the email address of user "another-admin" should be "[email protected]"
And the quota definition of user "another-admin" should be "12 MB"

@notToImplementOnOCIS
Scenario: a subadmin should be able to edit user information with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -155,7 +155,7 @@ Feature: edit users
Then the display name of user "another-subadmin" should be "Anne Brown"
And the email address of user "another-subadmin" should be "[email protected]"
And the quota definition of user "another-subadmin" should be "12 MB"

@notToImplementOnOCIS
Scenario: a subadmin should not be able to edit user information of another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
8 changes: 4 additions & 4 deletions tests/acceptance/features/apiProvisioning-v2/enableUser.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ Feature: enable user
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "Alice" should be disabled

@notToImplementOnOCIS
Scenario: subadmin should be able to enable user in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -120,7 +120,7 @@ Feature: enable user
Then the OCS status code should be "200"
And the HTTP status code should be "200"
And user "Alice" should be enabled

@notToImplementOnOCIS
Scenario: subadmin should not be able to enable user not in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -133,7 +133,7 @@ Feature: enable user
Then the OCS status code should be "997"
And the HTTP status code should be "401"
And user "Alice" should be disabled

@notToImplementOnOCIS
Scenario: subadmin should be able to enable user with subadmin permissions in their group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand All @@ -148,7 +148,7 @@ Feature: enable user
Then the OCS status code should be "200"
And the HTTP status code should be "200"
And user "Alice" should be enabled

@notToImplementOnOCIS
Scenario: subadmin should not be able to enable another subadmin of same group
Given these users have been created with default attributes and without skeleton files:
| username |
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiProvisioning-v2/getSubAdmins.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @provisioning_api-app-required @skipOnLDAP
@api @provisioning_api-app-required @skipOnLDAP @notToImplementOnOCIS
Feature: get subadmins
As an admin
I want to be able to get the list of subadmins of a group
Expand Down
Loading