Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM. user cannot see the thumbnails of the shared image file #10495

Closed
ScharfViktor opened this issue Nov 6, 2024 · 2 comments · Fixed by #10501
Closed

OCM. user cannot see the thumbnails of the shared image file #10495

ScharfViktor opened this issue Nov 6, 2024 · 2 comments · Fixed by #10501
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@ScharfViktor
Copy link
Contributor

releated #10272

@rhafer and me think that it web issue. if you don't think so -> please move to ocis repo

ocis: 6.6.1+6f3322a3d
web: 11.0.1

setup: https://owncloud.dev/ocis/development/testing/#running-test-suite-with-federated-sharing-ocm with enabled vips
see how enable vips here: #10310 (comment)

Steps:

  • 2 users create connection
  • user1 creates folder f2 with .png file inside and shares to user2 -> user2 can see thumbnails of the image file
  • user1 shares .png file to user2
  • user2 tries to see .png file

Actual: user2 cannot see thumbnails and cannot open file in viewer

if I use https://github.com/owncloud/web/blob/master/docker-compose.yml (fresh ocis-rolling:master)-> user recipient cannot see thumbnails and open image files
image

cc @rhafer

@rhafer
Copy link
Contributor

rhafer commented Nov 6, 2024

@rhafer and me think that it web issue. if you don't think so -> please move to ocis repo

I think it's a web issue, because web does not even seem to request the thumbnail. (Unless we overlooked something)

@kulmann
Copy link
Contributor

kulmann commented Nov 6, 2024

I'm leaning towards it's a backend issue. The sharedWithMe endpoint claims that the image has application/octet-stream as mimetype. For those we don't fetch previews.

Screenshot 2024-11-06 at 16 44 05

@kulmann kulmann transferred this issue from owncloud/web Nov 6, 2024
@rhafer rhafer moved this from Qualification to Prio 2 in Infinite Scale Team Board Nov 7, 2024
@rhafer rhafer added the Priority:p2-high Escalation, on top of current planning, release blocker label Nov 7, 2024
@rhafer rhafer self-assigned this Nov 7, 2024
@rhafer rhafer moved this from Prio 2 to In progress in Infinite Scale Team Board Nov 7, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Nov 7, 2024
File shares need to use the base64 encoded path as the opaqueID, while
for folder shares the base64 encode '/' should work.

Fixes owncloud#10495
rhafer added a commit to rhafer/ocis that referenced this issue Nov 7, 2024
File shares need to use the base64 encoded path as the opaqueID, while
for folder shares the base64 encode '/' should work.

Fixes owncloud#10495
rhafer added a commit to rhafer/ocis that referenced this issue Nov 7, 2024
File shares need to use the base64 encoded path as the opaqueID, while
for folder shares the base64 encode '/' should work.

Fixes owncloud#10495
@micbar micbar closed this as completed in 4792071 Nov 7, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Nov 7, 2024
This was referenced Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants