Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): Use the correct opaqueId when Statting OCM shares #10501

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Nov 7, 2024

File shares need to use the base64 encoded path as the opaqueID, while for folder shares the base64 encode '/' should work.

Fixes #10495

@rhafer rhafer force-pushed the issue/10495 branch 2 times, most recently from abdee16 to 92b810a Compare November 7, 2024 11:03
@rhafer rhafer marked this pull request as ready for review November 7, 2024 11:03
@rhafer rhafer requested a review from micbar November 7, 2024 11:07
@rhafer
Copy link
Contributor Author

rhafer commented Nov 7, 2024

Hm, converting to draft again. Maybe there is a cleaner fix ...

@rhafer rhafer marked this pull request as draft November 7, 2024 11:18
@rhafer
Copy link
Contributor Author

rhafer commented Nov 7, 2024

Hm, converting to draft again. Maybe there is a cleaner fix ...

Nevermind. That didn't workout.

@rhafer rhafer marked this pull request as ready for review November 7, 2024 12:13
@micbar
Copy link
Contributor

micbar commented Nov 7, 2024

This needs a rebase.

File shares need to use the base64 encoded path as the opaqueID, while
for folder shares the base64 encode '/' should work.

Fixes owncloud#10495
This shoud silence some linter warning about copying lock values.
Copy link

sonarqubecloud bot commented Nov 7, 2024

@micbar micbar merged commit f11e3e0 into owncloud:master Nov 7, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Nov 7, 2024
fix(graph): Use the correct opaqueId when Statting OCM shares
@micbar micbar mentioned this pull request Nov 8, 2024
85 tasks
@micbar micbar mentioned this pull request Dec 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCM. user cannot see the thumbnails of the shared image file
2 participants