[oCIS] Batch delete can fail sometimes

[saw-jan]

Steps to reproduce

1. Upload 20-30 files
2. Delete all files

Expected behavior

expected all files are deleted

Actual behavior

some requests failed

HTTP log

DELETE /remote.php/dav/files/admin/simple-empy-folder HTTP/1.1
Host: host.docker.internal:9200
Connection: keep-alive
sec-ch-ua: " Not A;Brand";v="99", "Chromium";v="99", "Google Chrome";v="99"
sec-ch-ua-mobile: ?0
Authorization: Bearer eyJhbGciOiJQUzI1NiIsImtpZCI6IiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJ3ZWIiLCJleHAiOjE2NDkwNDQyMTEsImp0aSI6Ii1va20zLWR4S1pEckdQSFFGX0xKaUVra1I1VnBGVXN5IiwiaWF0IjoxNjQ5MDQzNjExLCJpc3MiOiJodHRwczovL2hvc3QuZG9ja2VyLmludGVybmFsOjkyMDAiLCJzdWIiOiJmNnF2RDdoMmE1SFJsOWl6QEVDQjJOQzBCenJfTG54ZmJrZ3BsNFZ1UzJYOXM3T25zZnpVRFBONHVOU2RfanhFZ19sV0EzNGpzdXlXYW51RnREUHRIRlEiLCJsZy50IjoiMSIsInNjcCI6InByb2ZpbGUgZW1haWwgb3BlbmlkIiwibGcuaSI6eyJkbiI6ImFkbWluIiwiaWQiOiJjbj1hZG1pbixvdT11c2VycyxkYz1vY2lzLGRjPXRlc3QiLCJ1biI6ImFkbWluIn0sImxnLnAiOiJpZGVudGlmaWVyLWxkYXAifQ.y0J3mncDowKCdqkF-v13TjakUFT0vCCgKouDvwTYoKwz8nQYxSpwwHy6MRi7WZUNcUmzwty0H1II9O7pTETBtbSY3EO6A7Sn3-OJHybj5kREUnTiuPm5EsWoQd5DRgnwQ7tWRcGLSnjUyAx3Vocgr6rfudmXDfgMun2Td14Cv9HTicuoRFUfAgds68PvmTCVKgFA8x6F7anS6n5ZfdPRWFa1Taboy7cTAbJd7V8rFBbChQuyccR6WtFLeAoUXQdgkGJJuHsIZ11eVAnFyjI3VkJR8rCSWLWRO9kr8dJrwyL3lSX-6atC6CWKOV5fqObjgLrHCYFfqGprk2elVq_RzQ
OCS-APIREQUEST: true
Accept: application/json, text/plain, */*
X-Requested-With: XMLHttpRequest
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/99.0.4844.84 Safari/537.36
X-Request-ID: b97b8fcb-2fcd-4e0c-99a5-747fcc3a2ddf
sec-ch-ua-platform: "Linux"
Origin: https://host.docker.internal:9200
Sec-Fetch-Site: same-origin
Sec-Fetch-Mode: cors
Sec-Fetch-Dest: empty
Referer: https://host.docker.internal:9200/files/spaces/personal/home/large-folder?items-per-page=100
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9

HTTP/1.1 404 Not Found
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Location
Content-Length: 0
Content-Security-Policy: default-src 'none';
Date: Mon, 04 Apr 2022 03:44:09 GMT
Vary: Origin
X-Content-Type-Options: nosniff
X-Download-Options: noopen
X-Frame-Options: SAMEORIGIN
X-Permitted-Cross-Domain-Policies: none
X-Robots-Tag: none
X-Xss-Protection: 1; mode=block

oCIS log

The server yields the following log on request failure

{
  "level":"error",
  "service":"storage",
  "pkg":"rgrpc",
  "traceid":"00000000000000000000000000000000",
  "error":"remove /var/lib/ocis/storage/users/spacetypes/personal/5d86bd6d-1991-4d8e-9e91-7ebef9e8b65e.flock: no such file or directory",
  "node":"marshaling error: json: unsupported value: encountered a cycle via *node.Node",
  "time":"2022-04-08T06:46:51Z",
  "message":"could not convert to storage space"
}
{
  "level":"error",
  "service":"storage",
  "pkg":"rgrpc",
  "traceid":"00000000000000000000000000000000",
  "error":"stat /var/lib/ocis/storage/users/spaces/dd/c2004c-0977-11eb-9d3f-a793888cd0f8/nodes/dd/c2/00/4c/-0977-11eb-9d3f-a793888cd0f8/simple.pdf: no such file or directory",
  "childpath":"/var/lib/ocis/storage/users/spaces/dd/c2004c-0977-11eb-9d3f-a793888cd0f8/nodes/dd/c2/00/4c/-0977-11eb-9d3f-a793888cd0f8/simple.pdf",
  "time":"2022-04-08T06:46:51Z",
  "message":"could not stat child entry"
}
{
  "level":"error",
  "service":"storage",
  "pkg":"rgrpc",
  "traceid":"00000000000000000000000000000000",
  "error":"remove /var/lib/ocis/storage/users/spaces/dd/c2004c-0977-11eb-9d3f-a793888cd0f8/nodes/dd/c2/00/4c/-0977-11eb-9d3f-a793888cd0f8.flock: no such file or directory",
  "status":{
    "code":15,
    "message":"error listing spaces",
    "trace":"00000000000000000000000000000000"
  },
  "filters":
    [
      {
        "type":2,
        "Term":{
          "Id":{
            "opaque_id":"ddc2004c-0977-11eb-9d3f-a793888cd0f8!ddc2004c-0977-11eb-9d3f-a793888cd0f8"
          }
        }
      }
    ],
  "time":"2022-04-08T06:46:51Z",
  "message":"failed to list storage spaces"
}

[individual-it]

This looks like an ocis issue to me. @kulmann @butonic what do you think moving to ocis?

[individual-it]

@saw-jan please skip those tests for now for ocis and add a todo here to unskip the tests again

[saw-jan]

[QA] TODO:

• unskip the tests related to this issue (skipped in [tests-only][full-ci] Skip tests on oCIS related to batch request web#6828)

[kobergj]

Reason is the flock issue. Closing this in favor of #3757