Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some request fail while doing batch request in OCIS #6796

Closed
SwikritiT opened this issue Apr 21, 2022 · 11 comments
Closed

Some request fail while doing batch request in OCIS #6796

SwikritiT opened this issue Apr 21, 2022 · 11 comments
Assignees
@saw-jan
Labels
QA:team

Comments

@SwikritiT
Copy link
Contributor

SwikritiT commented Apr 21, 2022 •
edited by saw-jan
Loading

Seems like batch requests have not been working properly in ocis. There has been some tests failure related to batch request while deleting, restoring

Batch Restore

Batch Delete

Batch Share (share with multiple users/groups)

Upload Folder containing multiple files/fodlers
@SwikritiT
Copy link
Contributor Author

@pascalwengerter @kulmann

@SwikritiT SwikritiT removed the QA:team label Apr 21, 2022
@SwikritiT
Copy link
Contributor Author

SwikritiT commented Apr 22, 2022 •
edited
Loading

webUITrashbinDelete/trashbinDelete.feature:105 failed
https://drone.owncloud.com/owncloud/ocis/10816/50/9

Scenario: Delete folders with dot in the name from trashbin (attempt 1, retried) # features/webUITrashbinDelete/trashbinDelete.feature:105
   ✔ Before # setup.js:41
   ✔ Before # setup.js:45
   ✔ Before # setup.js:49
   ✔ Before # setup.js:66
   ✔ Before # setup.js:73
   ✔ Before # setup.js:84
   ✔ Before # stepDefinitions/filesContext.js:17
   ✔ Before # stepDefinitions/generalContext.js:199
   ✔ Before # stepDefinitions/generalContext.js:237
   ✔ Before # stepDefinitions/middlewareContext.js:46
   ✔ Given user "Alice" has been created with default attributes and without skeleton files in the server # stepDefinitions/middlewareContext.js:66
   ✔ Given user "Alice" has created file "lorem.txt" in the server # stepDefinitions/middlewareContext.js:66
   ✔ Given user "Alice" has created file "lorem-big.txt" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created file "sample,1.txt" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created folder "simple-folder" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created folder "Folder,With,Comma" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created file "simple-folder/lorem.txt" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has created file "simple-folder/lorem-big.txt" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And user "Alice" has uploaded file "data.zip" to "data.zip" in the server # stepDefinitions/middlewareContext.js:66
   ✔ And the following files have been deleted by user "Alice" in the server # stepDefinitions/middlewareContext.js:76
       | name              |
       | lorem.txt         |
       | simple-folder     |
       | sample,1.txt      |
       | lorem-big.txt     |
       | Folder,With,Comma |
       | data.zip          |
   ✔ And user "Alice" has logged in using the webUI # stepDefinitions/loginContext.js:64
   ✔ And the user has browsed to the trashbin page # stepDefinitions/filesContext.js:74
   ✔ Given user "Alice" has created the following folders in the server # stepDefinitions/middlewareContext.js:76
       | folders  |
       | fo.      |
       | fo.1     |
       | fo...1.. |
       | fo.xyz   |
   ✔ And the following folders have been deleted by user "Alice" in the server # stepDefinitions/middlewareContext.js:76
       | name     |
       | fo.      |
       | fo.1     |
       | fo...1.. |
       | fo.xyz   |
   ✔ And the user has browsed to the trashbin page # stepDefinitions/filesContext.js:74
   ✔ And the user has reloaded the current page of the webUI # stepDefinitions/filesContext.js:451
   ✔ When the user batch deletes these files using the webUI # stepDefinitions/filesContext.js:487
       | name     |
       | fo.      |
       | fo.1     |
       | fo...1.. |
       | fo.xyz   |
   ✖ Then the deleted elements should not be listed on the webUI # stepDefinitions/filesContext.js:402
       AssertionError [ERR_ASSERTION]: Expected resource 'fo.' to be 'not present' but found 'present'
           + expected - actual

           -false
           +true

           at assertElementsAreNotListed (/srv/app/web/tests/acceptance/stepDefinitions/filesContext.js:939:12)
           at runMicrotasks (<anonymous>)
           at processTicksAndRejections (internal/process/task_queues.js:95:5)
   - And the deleted elements should not be listed on the webUI after a page reload # stepDefinitions/filesContext.js:406
   ✔ After # stepDefinitions/middlewareContext.js:60
   ✔ After # stepDefinitions/generalContext.js:255
   ✔ After # stepDefinitions/generalContext.js:224
   ✔ After # stepDefinitions/generalContext.js:165
   ✔ After # setup.js:117
   ✔ After # setup.js:113
   ✔ After # setup.js:109
   ✔ After # setup.js:102
   ✔ After # setup.js:93

@saw-jan
Copy link
Member

saw-jan commented Apr 28, 2022 •
edited
Loading

Those problems seem to be with oCIS server. Issues have been raised:
owncloud/ocis#3612
owncloud/ocis#3613
owncloud/ocis#3614
owncloud/ocis#3616

TODO:

@saw-jan saw-jan self-assigned this Apr 28, 2022
@saw-jan saw-jan mentioned this issue Apr 28, 2022
Closed
9 tasks
@saw-jan
Copy link
Member

saw-jan commented May 4, 2022

Sharing failed: https://drone.owncloud.com/owncloud/web/25227/64/15
Restore failed: https://drone.owncloud.com/owncloud/web/25226/68/15

This was referenced May 4, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@saw-jan
Copy link
Member

saw-jan commented May 5, 2022

Seen again: https://drone.owncloud.com/owncloud/web/25313/64/15

@saw-jan
Copy link
Member

saw-jan commented May 9, 2022

Batch restore failed nightly: https://drone.owncloud.com/owncloud/web/25402/68/15

@SwikritiT
Copy link
Contributor Author

SwikritiT commented May 10, 2022 •
edited by saw-jan
Loading

Sharing related failure in https://drone.owncloud.com/owncloud/web/25449/64/15

webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:52

Trashbin related failure:https://drone.owncloud.com/owncloud/web/25449/68/15

webUITrashbinDelete/trashbinDelete.feature:105
webUITrashbinRestore/trashbinRestore.feature:84
webUITrashbinDelete/trashbinDelete.feature:130

upload: https://drone.owncloud.com/owncloud/web/25449/45/20

webUIUpload/upload.feature:22

@SwikritiT
Copy link
Contributor Author

Sharing related failure: https://drone.owncloud.com/owncloud/web/25488/63/15

webUISharingFolderAdvancedPermissionsGroups/shareAdvancePermissionsGroup.feature:54

Trashbin related failure: https://drone.owncloud.com/owncloud/web/25488/68/15

webUITrashbinRestore/trashbinRestore.feature:115
webUITrashbinRestore/trashbinRestore.feature:84

@SwikritiT
Copy link
Contributor Author

The failures have been pretty much consistent in recent nightly builds

@saw-jan
Copy link
Member

saw-jan commented May 12, 2022

Tests look pretty stable with the latest oCIS.
The culprit issue in oCIS has been fixed (owncloud/ocis#3757).
Bumping is on the way (#6946). CI should be stable after bumping.

IMO, this issue can be closed alongside the PR merge.

@pascalwengerter
Copy link
Contributor

Closing via #6946, thanks for the efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tests-only][full-ci] Skip tests on oCIS related to batch request owncloud/web
3 participants
@pascalwengerter @SwikritiT @saw-jan