Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Skip tests on oCIS related to batch request #6828

Closed
wants to merge 2 commits into from
Closed

[tests-only][full-ci] Skip tests on oCIS related to batch request #6828

wants to merge 2 commits into from

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Apr 28, 2022 •
edited
Loading

Description

Acceptance tests that does batch actions are skipped due to following issues in oCIS
owncloud/ocis#3613, owncloud/ocis#3612, owncloud/ocis#3614, owncloud/ocis#3616

Related Issue

closes #6796

How Has This Been Tested?

  • test environment: CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Apr 28, 2022
@saw-jan saw-jan mentioned this pull request Apr 28, 2022
Closed
@saw-jan saw-jan changed the title [tests-only][full-ci] Skip tests on oCIS related to batch actions [tests-only][full-ci] Skip tests on oCIS related to batch request Apr 28, 2022
This was referenced Apr 28, 2022
Closed
Closed
Closed
Closed
@ownclouders
Copy link
Contributor

ownclouders commented Apr 28, 2022 •
edited
Loading

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/25151/12/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/25151/tracing/unstructured-collection-of-testable-space-interactions-alice-2022-5-3-09-04-06.zip

@saw-jan saw-jan force-pushed the skip-tests-ocis branch from 5493381 to fae16a3 Compare May 3, 2022 06:38
@saw-jan saw-jan marked this pull request as ready for review May 3, 2022 09:16
pascalwengerter
pascalwengerter requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to discuss this with the web team before merging

@saw-jan saw-jan mentioned this pull request May 4, 2022
Closed
@kulmann
Copy link
Contributor

kulmann commented May 4, 2022

@saw-jan are the tests still flaky with most recent ocis? I didn't observe them failing during the (heave drone-load) last days to be honest. But I might be mistaken. Could you clarify?

@saw-jan
Copy link
Member Author

saw-jan commented May 5, 2022

@saw-jan are the tests still flaky with most recent ocis? I didn't observe them failing during the (heave drone-load) last days to be honest. But I might be mistaken. Could you clarify?

Yeah, there's one today (#6796 (comment))
Since others have not appeared, I could not say anything. I will try to reproduce them.

@saw-jan
Copy link
Member Author

saw-jan commented May 5, 2022

@kulmann I retested them. They can fail intermittently.

@saw-jan saw-jan force-pushed the skip-tests-ocis branch from fae16a3 to e708aa8 Compare May 5, 2022 09:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan requested a review from pascalwengerter May 9, 2022 11:40
@kulmann
Copy link
Contributor

kulmann commented May 10, 2022

Related? owncloud/ocis#3757

@saw-jan
Copy link
Member Author

saw-jan commented May 11, 2022 •
edited
Loading

Related? owncloud/ocis#3757

Seems like it.
We may not want to skip those tests if there will be a fix.
So, close this one?

@saw-jan
Copy link
Member Author

saw-jan commented May 12, 2022

I think, we no longer need this PR, the latest oCIS has some possible fixes. Commit id bump is in progress (#6946)

Closing here!

@saw-jan saw-jan closed this May 12, 2022
@pascalwengerter pascalwengerter deleted the skip-tests-ocis branch June 29, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade Awaiting requested review from fschade

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@Talank Talank Awaiting requested review from Talank

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some request fail while doing batch request in OCIS
4 participants
@saw-jan @ownclouders @kulmann @pascalwengerter