Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oCIS] Sharing with multiple users/groups fails sometimes #3613

Closed
saw-jan opened this issue Apr 28, 2022 · 3 comments
Closed

[oCIS] Sharing with multiple users/groups fails sometimes #3613

saw-jan opened this issue Apr 28, 2022 · 3 comments
Labels

Comments

@saw-jan
Copy link
Member

saw-jan commented Apr 28, 2022

Steps to reproduce

Run any multi-sharing acceptance test multiple times:
e.g., webUISharingFolderAdvancedPermissionMultipleUsers/sharedFolderWithMultipleUsersAdvancedPermissions.feature:47

Expected behaviour

sharing successful

Actual behaviour

test-test_feature-L61

HTTP log

Request URL: https://host.docker.internal:9200/ocs/v1.php/apps/files_sharing/api/v1/shares
Request Method: POST
Status Code: 200 OK
Remote Address: 172.17.0.1:9200
Referrer Policy: strict-origin-when-cross-origin
Accept: */*
Accept-Encoding: gzip, deflate, br
Accept-Language: en-US,en;q=0.9
authorization: Bearer eyJhbGciOiJ...
Connection: keep-alive
Content-Length: 63
content-type: application/x-www-form-urlencoded
Host: host.docker.internal:9200
ocs-apirequest: true
Origin: https://host.docker.internal:9200
Referer: https://host.docker.internal:9200/files/spaces/personal/home?items-per-page=100
sec-ch-ua: "Chromium";v="94", "Google Chrome";v="94", ";Not A Brand";v="99"
sec-ch-ua-mobile: ?0
sec-ch-ua-platform: "Linux"
Sec-Fetch-Dest: empty
Sec-Fetch-Mode: cors
Sec-Fetch-Site: same-origin
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36
x-request-id: 0e0fe0d3-2edd-4569-bfd3-156c87e1fdb9
x-requested-with: XMLHttpRequest
# Form data
shareType: 0
shareWith: Brian
path: /simple-folder
permissions: 9

# Response
Access-Control-Allow-Credentials: true
Access-Control-Allow-Origin: *
Access-Control-Expose-Headers: Location
Content-Length: 141
Content-Type: text/xml; charset=utf-8
Date: Fri, 08 Apr 2022 06:12:29 GMT
Ocs-Api-Version: 1
Vary: Origin

<?xml version="1.0" encoding="UTF-8"?>
<ocs>
  <meta>
    <status>error</status>
    <statuscode>404</statuscode>
    <message>Not found</message>
  </meta>
</ocs>

oCIS log

2022-04-08 05:03:58 ERR github.com/cs3org/reva/[email protected]/pkg/storage/utils/decomposedfs/upload.go:95
> Decomposedfs: could not write checksum
error="Decomposedfs: could not set extended attribute: xattr.Set /var/lib/ocis/storage/metadata/spaces/95/cb8724-03b2-11eb-a0a6-c33ef8ef53ad/nodes/cd/72/fb/51/-2e6a-431c-b6ce-636a4897b8f1 user.ocis.cs.sha1: no such file or directory"
binPath=/var/lib/ocis/storage/metadata/uploads/201e04ed-4702-4567-9797-6de8fdcc307d
csType=sha1
hash="�S�L�](Ɯ0���0�Q\x1c� �"
info={
  "ID":"201e04ed-4702-4567-9797-6de8fdcc307d",
  "IsFinal":false,
  "IsPartial":false,
  "MetaData":
    {
      "dir":"/groups",
      "filename":"509a9dcd-bb37-4f4f-a01a-19dca27d9cfa",
      "lockid":""
    },
  "Offset":372,
  "PartialUploads":null,
  "Size":0,
  "SizeIsDeferred":false,
  "Storage":
    {
      "BinPath":"/var/lib/ocis/storage/metadata/uploads/201e04ed-4702-4567-9797-6de8fdcc307d",
      "Idp":"",
      "LogLevel":"trace",
      "NodeId":"cd72fb51-2e6a-431c-b6ce-636a4897b8f1","NodeName":"509a9dcd-bb37-4f4f-a01a-19dca27d9cfa",
      "NodeParentId":"7f73a794-4dd6-4545-b865-cbd2ae58c4fd",
      "SpaceRoot":"95cb8724-03b2-11eb-a0a6-c33ef8ef53ad",
      "Type":"OCISStore","UserId":"95cb8724-03b2-11eb-a0a6-c33ef8ef53ad",
      "UserName":"",
      "UserType":"application"
    }
  }
pid=1
targetPath=/var/lib/ocis/storage/metadata/spaces/95/cb8724-03b2-11eb-a0a6-c33ef8ef53ad/nodes/cd/72/fb/51/-2e6a-431c-b6ce-636a4897b8f1
{
  "level":"error",
  "service":"storage",
  "pkg":"rgrpc","traceid":"00000000000000000000000000000000",
  "error":"remove /var/lib/ocis/storage/users/spacetypes/personal/4f4e0326-c7d1-4dc6-bf43-f0637d1c0516.flock: no such file or directory",
  "node":"marshaling error: json: unsupported value: encountered a cycle via *node.Node",
  "time":"2022-04-08T05:04:09Z",
  "message":"could not convert to storage space"}
{
  "level":"error",
  "service":"notifications",
  "error":"could not send mail: dial tcp 127.0.0.1:1025: connect: connection refused",
  "event":"ShareCreated",
  "time":"2022-04-08T05:04:09Z",
  "message":"failed to send a message"
}
@individual-it
Copy link
Member

This looks like an ocis issue to me. @kulmann @butonic what do you think moving to ocis?

@saw-jan please skip those tests for now for ocis and add a todo here to unskip the tests again

@saw-jan
Copy link
Member Author

saw-jan commented Apr 28, 2022

[QA] TODO:

@kobergj
Copy link
Collaborator

kobergj commented May 10, 2022

Reason is the flock issue. Closing this in favor of #3757

@kobergj kobergj closed this as completed May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants