[oCIS] Uploading folder containing multiple files/folders can fail sometimes

[saw-jan]

Steps to reproduce

Run any multi-sharing acceptance test multiple times: webUIUpload/upload.feature:22

Folder structure:

CUSTOM\
CUSTOM\lorem.txt
CUSTOM\sub1\
CUSTOM\sub1\lorem.txt
CUSTOM\sub1\new-lorem.txt
CUSTOM\sub2\
CUSTOM\sub2\sub3
CUSTOM\sub2\sub3\new-lorem.txt

Expected behavior

expected all files are deleted

Actual behavior

some requests failed

HTTP log

POST /remote.php/dav/files/Alice/CUSTOM HTTP/1.1 
Host: host.docker.internal:9200 
Connection: keep-alive 
Content-Length: 0 
sec-ch-ua: "Chromium";v="94", "Google Chrome";v="94", ";Not A Brand";v="99" 
Upload-Length: 699 
Tus-Resumable: 1.0.0 
sec-ch-ua-mobile: ?0 
Authorization: Bearer eyJhbGciOiJQUzI1NiIsImtpZCI6IiIsInR5cCI6IkpXVCJ9.eyJhdWQiOiJ3ZWIiLCJleHAiOjE2NTExNDA1ODEsImp0aSI6Ii1KU2lRLVgxWXppQmRsSElaVlhKV05xOHdGeEdnNzczIiwiaWF0IjoxNjUxMTM5OTgxLCJpc3MiOiJodHRwczovL2hvc3QuZG9ja2VyLmludGVybmFsOjkyMDAiLCJzdWIiOiJxWm55UmRpeURqVnZ2eEp5QDktbHZ2b0M0ZS1KRC00UTNyWTRCTk1mazVUZTQ5T3BTNVZkN0J3VzlnaDdqNkM2S1ZUbHE5WWlhV0ZLMWtPUTMxZjB6U2ciLCJsZy50IjoiMSIsInNjcCI6Im9wZW5pZCBwcm9maWxlIGVtYWlsIiwibGcuaSI6eyJkbiI6IkFsaWNlIEhhbnNlbiIsImlkIjoiY249QWxpY2Usb3U9dXNlcnMsZGM9b2NpcyxkYz10ZXN0IiwidW4iOiJBbGljZSJ9LCJsZy5wIjoiaWRlbnRpZmllci1sZGFwIn0.gCdDbaypfhyeBSvCYwdYUCCmhO42jgYoX2WHXXIx29MtwtijJvBgsnXbdm24dw5hALPwNUM69dh9Y2oo2_aXPiJG5ZCe6Ubng5NtkZPyt0npe9ZKQs7a9ZQe8HKZBhUDN4OReVvTr7bHoQSjF-X94tqHKBVMUd2cc4a2etnDDupATuUmhsBVl3b2_I2nLD8957MMjcREDDBtFJNphUW3HHv1H2Xp47osnDAyKq2VbB4Fx-5UkFMF9fa6gr9-0roDrPOmbwMy11jUW4tmhpRILMmN5TwYs2OwVq3qXFw_oix6O5YqZlsMeWKPW33jeqxtge1sQNuVariemMixCXwLgQ 
User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.61 Safari/537.36 
Upload-Metadata: currentFolder Lw==,relativeFolder Q1VTVE9N,relativePath Q1VTVE9NL2xvcmVtLnR4dA==,route W29iamVjdCBPYmplY3Rd,tusEndpoint aHR0cHM6Ly9ob3N0LmRvY2tlci5pbnRlcm5hbDo5MjAwL3JlbW90ZS5waHAvZGF2L2ZpbGVzL0FsaWNlL0NVU1RPTQ==,webDavBasePath L2ZpbGVzL0FsaWNl,name bG9yZW0udHh0,type dGV4dC9wbGFpbg==,filetype dGV4dC9wbGFpbg==,filename bG9yZW0udHh0 
sec-ch-ua-platform: "Linux" 
Accept: */* 
Origin: https://host.docker.internal:9200 
Sec-Fetch-Site: same-origin 
Sec-Fetch-Mode: cors 
Sec-Fetch-Dest: empty 
Referer: https://host.docker.internal:9200/files/spaces/personal/home?items-per-page=100 
Accept-Encoding: gzip, deflate, br 
Accept-Language: en-US,en;q=0.9


HTTP/1.1 412 Precondition Failed
Access-Control-Allow-Headers: Tus-Resumable, Upload-Length, Upload-Metadata, If-Match
Access-Control-Allow-Origin: * 
Access-Control-Expose-Headers: Tus-Resumable, Location 
Content-Length: 0 
Content-Security-Policy: default-src 'none'; 
Date: Thu, 28 Apr 2022 09:59:42 GMT 
Tus-Extension: creation,creation-with-upload,checksum,expiration 
Tus-Resumable: 1.0.0 
X-Content-Type-Options: nosniff 
X-Download-Options: noopen 
X-Frame-Options: SAMEORIGIN 
X-Permitted-Cross-Domain-Policies: none 
X-Robots-Tag: none 
X-Xss-Protection: 1; mode=block

oCIS log

The server yields the following log on request failure

{
  "level":"error",
  "service":"storage",
  "pkg":"rgrpc",
  "traceid":"00000000000000000000000000000000",
  "error":"remove /var/lib/ocis/storage/users/spacetypes/personal/fdf22c79-1993-44a3-b573-6e96552bdf53.flock: no such file or directory",
  "node":"marshaling error: json: unsupported value: encountered a cycle via *node.Node",
  "time":"2022-04-28T09:43:26Z",
  "message":"could not convert to storage space"
}

[saw-jan]

[QA] TODO:
- [ ] unskip the tests related to this issue (skipped in owncloud/web#6828)
Fix in the source was applied instead

[kobergj]

Reason is the flock issue. Closing this in favor of #3757