Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing NG] permissions for a drive are missing its members #8352

Closed
JammingBen opened this issue Feb 2, 2024 · 1 comment
Closed

[Sharing NG] permissions for a drive are missing its members #8352

JammingBen opened this issue Feb 2, 2024 · 1 comment
Assignees
Labels

Comments

@JammingBen
Copy link
Contributor

Describe the bug

When fetching the permissions of a drive they are missing its members.

Steps to reproduce

  1. Create a drive and add some members and links to it.
  2. Fetch permissions for that drive: curl "https://localhost:9200/graph/v1beta1/drives/{drive-id}/items/{item-id}/permissions" -u admin:admin -vk | jq

Expected behavior

All members and links should be represented as a permission in the server's response.

Actual behavior

Members are missing, the server only returns the links.

cc @rhafer

@rhafer
Copy link
Contributor

rhafer commented Mar 7, 2024

I just noticed, that while we have implemented
GET /graph/v1beta1/drives and /graph/v1beta1/me/drives (which also return the permissions in the "new" format)

we're still missing the GET /graph/v1beta1/drives/{drive-id}

scratch that. I think we should not be returning permissions with the drives response at all on the v1beta1 implementation. This should be added to the driveItem related endpoints. (MS Graph does not specific the permissions relation for drives)

graph/v1beta1/drives/items/{item-id}/permissions (as requested in this issue)
and graph/v1beta1/drives/{driveid}/root/permissions

rhafer added a commit to rhafer/ocis that referenced this issue Mar 13, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Mar 14, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Mar 14, 2024
In order to work with (e.g. get/delete) permissions granted to space
we need to give them a stable id. As the CS3 API don't provide an id
we generate it base on the id of the identity that the permission applies
to. For users we use "u:<userid>" for groups "g:<groupid>".

Closes: owncloud#8352
rhafer added a commit to rhafer/ocis that referenced this issue Mar 14, 2024
rhafer added a commit to rhafer/ocis that referenced this issue Mar 14, 2024
In order to work with (e.g. get/delete) permissions granted to space
we need to give them a stable id. As the CS3 API don't provide an id
we generate it base on the id of the identity that the permission applies
to. For users we use "u:<userid>" for groups "g:<groupid>".

Closes: owncloud#8352
@rhafer rhafer closed this as completed in a326d95 Mar 18, 2024
rhafer added a commit that referenced this issue Mar 18, 2024
In order to work with (e.g. get/delete) permissions granted to space
we need to give them a stable id. As the CS3 API don't provide an id
we generate it base on the id of the identity that the permission applies
to. For users we use "u:<userid>" for groups "g:<groupid>".

Closes: #8352
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants