-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(sharing): Return space permissions when looking up space root #8642
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This role was renamed to "Manager" a while ago.
…1 format This reworks the cs3PermissionsToLibreGraph() so that it is able to return the libreGraph.Permissions in the legacy and the new v1beta1 format. The main differences between both are that v1beta1 returns the identities in the 'grantedToV2' property and the 'roles' are returned as IDs instead of the legacy role names.
In order to work with (e.g. get/delete) permissions granted to space we need to give them a stable id. As the CS3 API don't provide an id we generate it base on the id of the identity that the permission applies to. For users we use "u:<userid>" for groups "g:<groupid>". Closes: owncloud#8352
@JammingBen You might wanna try this. Should fix #8352. We're still lacking support for updating/deleting space permissions via Will work on that next. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Web, works well as far as I can see!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question. Rest looks good 👍
Make
GET https://localhost:9200/graph/v1beta1/drives/{{driveid}}/items/{{itemid}}/permissions
work for spacerootsThis is still missing link permission on the space root.