Backport thumbnailer fixes to stable-5.0 #10270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wncloud#9035) * feat: add maximum image dimension to be processed by the thumbnailer * chore: make golangci-lint happy (cherry picked from commit 9db3fd0)
…wncloud#9069) (cherry picked from commit 06bb8c9)
Thumbnail max input width and height need to be the same, because images can be portrait or landscape. See owncloud#9234 (cherry picked from commit 6117e19)
rhafer
force-pushed
the
backport/5.0/thumbnailer
branch
from
761f02d to
d0ab77c
Compare
This moves the ratelimit ('THUMBNAILS_MAX_CONCURRENT_REQUESTS') from the
HTTP endpoint to the GRPC endpoint. The HTTP endpoint is just used for
downloading already created thumbnails. But the resource consuming part of
thumbnail generation happens in the GRPC service.
(cherry picked from commit e2d7251)
|
Making this a draft again. I think I just found a missing piece. |
|
micbar
approved these changes
Oct 16, 2024
|
Needs a second approval. |
kobergj
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the following fixes to stable-5.0
#9035
#9069
#10225