[full-ci] Refactor storage configuration to make it similar to other oCIS configuration #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
💥 Acceptance test accountsUITests failed. Further test are cancelled... |
C0rby
changed the title
|
Lesson for next time: Open multiple smaller PRs instead of one big PR... 😿 |
C0rby
requested review from
micbar,
phil-davis and
individual-it
as code owners
C0rby
force-pushed
the
storage-config
branch
2 times, most recently
from
64b9d3d to
42e83f3
Compare
added 6 commits
April 25, 2022 16:10
Try to prevent concurrent read/write access on a global map in go-chi
phil-davis
reviewed
Apr 26, 2022
9 tasks
|
Kudos, SonarCloud Quality Gate passed! |
wkloucek
approved these changes
Apr 26, 2022
|
Follow up in #3589 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read this issue for more details
The configuration and service commands now live in their own packages in the extensions directory. The configuration is missing the env variables and descriptions. They will be added in following PRs. Also there might be some more clean ups possible and some configuration could be added to the common struct but this can be done later as well.