[full-ci] config env #3589
Merged
[full-ci] config env #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
This was referenced Apr 26, 2022
Merged
Closed
micbar
reviewed
May 2, 2022
micbar
reviewed
May 2, 2022
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
reviewed
May 3, 2022
butonic
approved these changes
May 3, 2022
micbar
requested review from
phil-davis,
individual-it,
kulmann and
pascalwengerter
as code owners
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
wkloucek
removed request for
phil-davis,
individual-it,
kulmann and
pascalwengerter
micbar
reviewed
May 3, 2022
| @@ -73,17 +73,6 @@ func SharingConfigFromStruct(cfg *config.Config) map[string]interface{} { | |||
| "enable_expired_shares_cleanup": cfg.PublicSharingDrivers.SQL.EnableExpiredSharesCleanup, | |||
| "janitor_run_interval": cfg.PublicSharingDrivers.SQL.JanitorRunInterval, | |||
| }, | |||
| "owncloudsql": map[string]interface{}{ | |||
There was a problem hiding this comment.
why remove the PublicSharingDrivers?
There was a problem hiding this comment.
because there is no owncloudsql publicshare driver in reva: https://github.com/cs3org/reva/blob/afc8ead0c9a6a0acc5b46bf27a8b18ad458c098d/pkg/publicshare/manager/loader/loader.go#L23-L25
package loader
import (
// Load core share manager drivers.
_ "github.com/cs3org/reva/v2/pkg/publicshare/manager/cs3"
_ "github.com/cs3org/reva/v2/pkg/publicshare/manager/json"
_ "github.com/cs3org/reva/v2/pkg/publicshare/manager/memory"
// Add your own here
)
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
This reverts commit f588e90.
|
SonarCloud Quality Gate failed. |
ownclouders
pushed a commit
that referenced
this pull request
May 3, 2022
ownclouders
pushed a commit
that referenced
this pull request
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow up on #3569
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: