-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Extend tests coverage for different role capability for group #5742
[tests-only][full-ci]Extend tests coverage for different role capability for group #5742
Conversation
facb79e
to
103c5b3
Compare
103c5b3
to
91215e5
Compare
528862c
to
1d8a19b
Compare
d9befb3
to
1599800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
1599800
to
b2da969
Compare
c91cda9
to
1c2aa82
Compare
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/20735/86/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20735/tracing/file-alice-2023-3-23-10-18-59.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20735/tracing/multiple-spaces-can-be-managed-at-once-in-the-admin-settings-via-the-batch-actions-alice-2023-3-23-10-11-00.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20735/tracing/space-members-can-be-invited-with-an-expiration-date-alice-2023-3-23-10-20-38.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20735/tracing/space-members-can-be-invited-with-an-expiration-date-brian-2023-3-23-10-20-44.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20735/tracing/user-group-assignments-can-be-handled-via-batch-actions-admin-2023-3-23-10-12-13.zip |
bad5dab
to
1432522
Compare
In general here is a list of error codes returned by the ms graph api: https://learn.microsoft.com/en-us/graph/errors Now the
|
1432522
to
d124e56
Compare
d124e56
to
57b221a
Compare
57b221a
to
a28444d
Compare
Kudos, SonarCloud Quality Gate passed! |
…ity for group (#5742) * Extend tests coverage for different role capability for group * Remove unwanted scenario * Change http status code
…ity for group (#5742) * Extend tests coverage for different role capability for group * Remove unwanted scenario * Change http status code
…ity for group (#5742) * Extend tests coverage for different role capability for group * Remove unwanted scenario * Change http status code
Description
This PR extends tests coverage for different role user capability over group manipulation
rename group will be implemented in ocis owncloud/web#7947.
As Viktor Scharf told
403 Forbidden vs 401 Unauthorized. I would be expect 403 code. But we definitely have chaos here and often for developers - 401 ok. in case non-existent - 404 or 403. looking at witch checking is first.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: