-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks mostly good to me
I've build a docker image with this code and pushed it to arturneumann/owncloud-test-middleware:latest
Here a PR that tries it owncloud/web#6814
Signed-off-by: Kiran Parajuli <[email protected]>
c64af0c
to
0421621
Compare
I've rebased the PR and fixed the lint problems. we recently did lint updates in the repo, so you may have to do |
thanks for advise)) |
I ran the ocis CI with my docker image and everything was successful. https://drone.owncloud.com/owncloud/ocis/11003 CI in ocis is now waiting for a new version middleware |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. lgtm
I'll go ahead and merge this one and #109 and then release a new version of the middleware |
To unlock CI in ocis (webUITest failed), I need to switch the methods user creation in midleware:
Given user "Alice" has been created with default attributes and without skeleton files in the server
and
Given these users have been created with default attributes and without skeleton files in the server:
to graphApi
How tested:
BACKEND_HOST=https://localhost:9200 NODE_TLS_REJECT_UNAUTHORIZED=0 RUN_ON_OCIS=true TEST_WITH_GRAPH_API yarn start
curl -XPOST http://localhost:3000/init
curl -XPOST http://localhost:3000/execute -d '{"step": "Given user \"Alice\" has been created with default attributes and without skeleton files"}' -H "Content-Type: application/json"
Result: Alice should be created:
curl -k -u admin:admin https://localhost:9200/graph/v1.0/users/Alice