Fix bug where translations were missing on the share type filters (#1…

…2013)

changelog/unreleased/bugfix-missing-translations-share-type-filters

@@ -0,0 +1,6 @@
+Bugfix: Missing translations for share type filters
+
+We've fixed a bug, where the translations for the share type filters were missing.
+This was the case for the "Shared with me" and "Shared with others" page.
+
+https://github.com/owncloud/web/pull/12013

packages/web-app-files/src/views/shares/SharedWithMe.vue

@@ -252,7 +252,13 @@ export default defineComponent({
         uniqueShareTypes.push(ShareTypes.remote.value)
       }
 
-      return ShareTypes.getByValues(uniqueShareTypes)
+      return ShareTypes.getByValues(uniqueShareTypes).map((shareType) => {
+        return {
+          key: shareType.key,
+          value: shareType.value,
+          label: $gettext(shareType.label)
+        }
+      })
     })
 
     const fileOwners = computed(() => {

packages/web-app-files/src/views/shares/SharedWithOthers.vue

@@ -106,6 +106,7 @@ import { useGetMatchingSpace } from '@ownclouders/web-pkg'
 import SharesNavigation from '../../components/AppBar/SharesNavigation.vue'
 import { OutgoingShareResource, ShareTypes } from '@ownclouders/web-client'
 import { storeToRefs } from 'pinia'
+import { useGettext } from 'vue3-gettext'
 
 export default defineComponent({
   components: {
@@ -128,6 +129,7 @@ export default defineComponent({
     const configStore = useConfigStore()
     const appsStore = useAppsStore()
     const { options: configOptions } = storeToRefs(configStore)
+    const { $gettext } = useGettext()
 
     const resourcesStore = useResourcesStore()
 
@@ -150,7 +152,13 @@ export default defineComponent({
         uniqueShareTypes.push(ShareTypes.remote.value)
       }
 
-      return ShareTypes.getByValues(uniqueShareTypes)
+      return ShareTypes.getByValues(uniqueShareTypes).map((shareType) => {
+        return {
+          key: shareType.key,
+          value: shareType.value,
+          label: $gettext(shareType.label)
+        }
+      })
     })
     const selectedShareTypesQuery = useRouteQuery('q_shareType')
     const filteredItems = computed(() => {

packages/web-app-files/tests/unit/views/shares/SharedWithMe.spec.ts

@@ -13,7 +13,7 @@ import { defaultStubs, RouteLocation } from '@ownclouders/web-test-helpers'
 import { useSortMock } from '../../../../tests/mocks/useSortMock'
 import { mock } from 'vitest-mock-extended'
 import { defaultPlugins, mount, defaultComponentMocks } from '@ownclouders/web-test-helpers'
-import { ShareTypes, IncomingShareResource } from '@ownclouders/web-client'
+import { ShareTypes, IncomingShareResource, ShareType } from '@ownclouders/web-client'
 import SharedWithMeSection from '../../../../src/components/Shares/SharedWithMeSection.vue'
 
 vi.mock('../../../../src/composables/resourcesViewDefaults')
@@ -96,9 +96,11 @@ describe('SharedWithMe view', () => {
         })
         const filterItems = wrapper
           .findComponent<typeof ItemFilter>('.share-type-filter')
-          .props('items')
+          .props('items') as ShareType[]
+
         expect(wrapper.find('.share-type-filter').exists()).toBeTruthy()
-        expect(filterItems).toEqual([shareType1, shareType2])
+        expect(filterItems[0].value).toEqual(shareType1.value)
+        expect(filterItems[1].value).toEqual(shareType2.value)
       })
     })
     describe('shared by', () => {

packages/web-app-files/tests/unit/views/shares/SharedWithOthers.spec.ts

@@ -39,7 +39,10 @@ describe('SharedWithOthers view', () => {
       expect(wrapper.find('.no-content-message').exists()).toBeTruthy()
     })
     it('shows the files table when files are available', () => {
-      const mockedFiles = [mockDeep<IncomingShareResource>(), mockDeep<IncomingShareResource>()]
+      const mockedFiles = [
+        mockDeep<IncomingShareResource>({ shareTypes: [ShareTypes.user.value] }),
+        mockDeep<IncomingShareResource>({ shareTypes: [ShareTypes.user.value] })
+      ]
       const { wrapper } = getMountedWrapper({ files: mockedFiles })
       expect(wrapper.find('.no-content-message').exists()).toBeFalsy()
       expect(wrapper.find('resource-table-stub').exists()).toBeTruthy()
@@ -73,7 +76,11 @@ function getMountedWrapper({
   mocks = {},
   files = [],
   loading = false
-}: { mocks?: Record<string, unknown>; files?: IncomingShareResource[]; loading?: boolean } = {}) {
+}: {
+  mocks?: Record<string, unknown>
+  files?: IncomingShareResource[]
+  loading?: boolean
+} = {}) {
   vi.mocked(useResourcesViewDefaults).mockImplementation(() =>
     useResourcesViewDefaultsMock({
       paginatedResources: ref(files),