[tests-only] [full-ci] Remove acceptance test related to image preview #10670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
3 times, most recently
from
bb0fae6 to
76c6392
Compare
18 tasks
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
3 times, most recently
from
804a589 to
d6f82d1
Compare
Salipa-Gurung
changed the title
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
7 times, most recently
from
3f49b1b to
35e3ebe
Compare
Salipa-Gurung
requested review from
PrajwolAmatya,
saw-jan,
SagarGi and
amrita-shrestha
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
from
35e3ebe to
6cee957
Compare
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
from
6cee957 to
9274fc6
Compare
SagarGi
reviewed
Apr 15, 2024
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
2 times, most recently
from
45543fd to
82c4a42
Compare
saw-jan
reviewed
Apr 17, 2024
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
from
12973c8 to
025e71f
Compare
saw-jan
reviewed
Apr 24, 2024
grgprarup
reviewed
Apr 25, 2024
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
2 times, most recently
from
b3f7a52 to
a220d11
Compare
✖ When "Alice" opens a file "testavatar.png" in the media-viewer using the sidebar panel # tests/e2e/cucumber/steps/ui/resources.ts:798
locator.click: Error: strict mode violation: locator('xpath=//div[contains(@class, "files-side-bar")]//*[contains(@data-testid, "action-handler")]/span[text()="Preview"]') resolved to 2 elements:
1) <span data-testid="action-label" class="oc-files-conte…>Preview</span> aka getByRole('button', { name: 'Preview' }).first()
2) <span data-testid="action-label" class="oc-files-conte…>Preview</span> aka getByRole('button', { name: 'Preview' }).nth(1)
=========================== logs ===========================
waiting for locator('xpath=//div[contains(@class, "files-side-bar")]//*[contains(@data-testid, "action-handler")]/span[text()="Preview"]')
============================================================
at Object.previewMediaFromSidebarPanel (/var/www/owncloud/web/tests/e2e/support/objects/app-files/resource/actions.ts:1627:67)
at async Resource.previewMediaFromSidebarPanel (/var/www/owncloud/web/tests/e2e/support/objects/app-files/resource/index.ts:303:5)
at async World.<anonymous> (/var/www/owncloud/web/tests/e2e/cucumber/steps/ui/resources.ts:803:5) |
saw-jan
reviewed
Apr 25, 2024
Salipa-Gurung
force-pushed
the
test/remove-image-preview
branch
from
da2ea10 to
69d4e38
Compare
|
Salipa-Gurung
added a commit
that referenced
this pull request
Apr 26, 2024
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
7 tasks
Salipa-Gurung
added a commit
that referenced
this pull request
Apr 26, 2024
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
Salipa-Gurung
added a commit
that referenced
this pull request
Apr 26, 2024
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
Salipa-Gurung
added a commit
that referenced
this pull request
Apr 26, 2024
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
Salipa-Gurung
added a commit
that referenced
this pull request
Apr 29, 2024
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
Salipa-Gurung
added a commit
that referenced
this pull request
Apr 30, 2024
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
saw-jan
pushed a commit
that referenced
this pull request
May 2, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
saw-jan
pushed a commit
that referenced
this pull request
May 14, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
saw-jan
pushed a commit
that referenced
this pull request
May 15, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
anon-pradip
pushed a commit
to anon-pradip/web
that referenced
this pull request
May 15, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (owncloud#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes