[tests-only] [full-ci] Port PR #10670 #10837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
requested changes
Apr 26, 2024
Salipa-Gurung
force-pushed
the
forwardport-move-media-preview
branch
from
0b4f5ba to
2a1feec
Compare
saw-jan
reviewed
Apr 26, 2024
saw-jan
reviewed
Apr 26, 2024
Salipa-Gurung
force-pushed
the
forwardport-move-media-preview
branch
from
2a1feec to
1c90f47
Compare
Salipa-Gurung
force-pushed
the
forwardport-move-media-preview
branch
from
1c90f47 to
44ca539
Compare
|
Please, make compatible with the changes done in PR #10637 |
Salipa-Gurung
force-pushed
the
forwardport-move-media-preview
branch
from
44ca539 to
1b077a7
Compare
Salipa-Gurung
changed the title
#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator
Salipa-Gurung
force-pushed
the
forwardport-move-media-preview
branch
from
1b077a7 to
f96aed1
Compare
|
saw-jan
pushed a commit
that referenced
this pull request
May 14, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
7 tasks
saw-jan
pushed a commit
that referenced
this pull request
May 15, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
anon-pradip
pushed a commit
to anon-pradip/web
that referenced
this pull request
May 15, 2024
* [tests-only] [full-ci] Remove acceptance test related to image preview (owncloud#10670) * remove acceptance test related to media preview * address review * add assertion for media navigation action * change step description * select the first element found by locator * refactor test step to download from topbar * update step description * remove identical step implementation to download resource from media viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forward port PR #10670 moving media preview test from acceptance to e2e test.
Related Issue
Types of changes