Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] remove webUI acceptance test suites #10878

Merged
merged 1 commit into from
May 7, 2024
Merged

[tests-only] remove webUI acceptance test suites #10878

merged 1 commit into from
May 7, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 6, 2024 •
edited
Loading

Description

Removed COPY/MOVE webUI acceptance tests and covered the test cases in API tests owncloud/ocis#9083

Removed sharing indicator tests (see #10259 (comment))

  • check for sharing indicator

sufficient as a unit test, no e2e needed.

  • check for public link indicator

sufficient as a unit test, no e2e needed.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@saw-jan saw-jan added the QA:team label May 6, 2024
@saw-jan saw-jan self-assigned this May 6, 2024
This was referenced May 6, 2024
Merged
Closed
@saw-jan saw-jan force-pushed the tests/remove-acceptance-suites branch from 9208451 to dc209de Compare May 7, 2024 03:50
@saw-jan saw-jan marked this pull request as ready for review May 7, 2024 03:50
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ScharfViktor
ScharfViktor approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
only one test is failed (not related your PR)
app-provider issue
Screenshot 2024-05-07 at 08 34 23

@saw-jan saw-jan changed the title [tests-only][full-ci] remove webUI acceptance test suites [tests-only] remove webUI acceptance test suites May 7, 2024
@saw-jan
Copy link
Member Author

saw-jan commented May 7, 2024

only one test is failed (not related your PR)
app-provider issue

working on issue #10880

@saw-jan saw-jan force-pushed the tests/remove-acceptance-suites branch from dc209de to e576395 Compare May 7, 2024 11:11
@saw-jan saw-jan merged commit 320a2de into master May 7, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/remove-acceptance-suites branch May 7, 2024 12:20
saw-jan added a commit that referenced this pull request May 14, 2024
@saw-jan
test: remove webUI acceptance test suites (#10878)
ce6e9c1
@saw-jan saw-jan mentioned this pull request May 15, 2024
Merged
7 tasks
saw-jan added a commit that referenced this pull request May 15, 2024
@saw-jan
test: remove webUI acceptance test suites (#10878)
0c36e25
anon-pradip pushed a commit to anon-pradip/web that referenced this pull request May 15, 2024
@saw-jan @anon-pradip
test: remove webUI acceptance test suites (owncloud#10878)
5ec4a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @ScharfViktor