Redesign copy link modal #11310
Redesign copy link modal #11310
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| if (this.useDefaultRules()) { | ||
| if (enforcePassword && !this.hasRules()) { | ||
| rules.mustNotBeEmpty = {} | ||
| } |
There was a problem hiding this comment.
We might have password fields, that don't require a password, that is in conflict with the always added not empty rule.
Also only add not empty rule, when no other password policy is set, as it is redundant
There was a problem hiding this comment.
Uh I like it a lot! Feels to much cleaner.
Just a few nitpicks here and there. And creating links with an expiration date gives me a weird error underneath the password form: this is #11309Invalid body schema definition
packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
Outdated
Show resolved
Hide resolved
packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts
Outdated
Show resolved
Hide resolved
…t there are already policies, remove extra line on add link modal
AlexAndBear
force-pushed
the
issues/11204
branch
from
c6c1fc7 to
8b1537b
Compare
|
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: