Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign copy link modal #11310

Merged
merged 17 commits into from
Aug 5, 2024
Merged

Redesign copy link modal #11310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
569b2e6
Fix extra empty line displayed
AlexAndBear Jul 31, 2024
bcd8199
Init
AlexAndBear Jul 31, 2024
58be716
Passwords can be empty
AlexAndBear Jul 31, 2024
2b1f71f
Remove password empty check as already fulfilled by password policy
AlexAndBear Jul 31, 2024
b6a43e7
Don't show extra must not be empty rule, when password is enforced bu…
AlexAndBear Jul 31, 2024
537db72
enhance passwordPolicy tests
AlexAndBear Jul 31, 2024
488f777
Add tests for simple mode
AlexAndBear Jul 31, 2024
2ea3534
Remove weird callback orgy, where links were copied multiple times to…
AlexAndBear Jul 31, 2024
dfefb8b
Cleanup
AlexAndBear Aug 1, 2024
8b1537b
Cleanup
AlexAndBear Aug 1, 2024
006f116
Fix e2e tests
AlexAndBear Aug 1, 2024
cc57ba6
Lint
AlexAndBear Aug 1, 2024
efe3cc6
fix more e2e
AlexAndBear Aug 1, 2024
11fe1e2
fix more e2e
AlexAndBear Aug 1, 2024
543606e
fix more e2e
AlexAndBear Aug 1, 2024
2eea11c
Rm blank
AlexAndBear Aug 2, 2024
3af0908
Add changelog item
AlexAndBear Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-redesign-share-link-modal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Redesign share link modal

We've redesigned the share link modal to make it easier to share.
The new modal is more user-friendly and provides a better experience for sharing.

https://github.com/owncloud/web/pull/11310
https://github.com/owncloud/web/issues/11204
4 changes: 0 additions & 4 deletions packages/design-system/src/components/OcModal/OcModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,10 +499,6 @@ export default defineComponent({
line-height: 1.625;
padding: var(--oc-space-medium) var(--oc-space-medium) 0;

span {
color: var(--oc-color-text-default);
}

kulmann marked this conversation as resolved.
Show resolved Hide resolved
&-message {
margin-bottom: var(--oc-space-medium);
margin-top: var(--oc-space-small);
Expand Down
3 changes: 1 addition & 2 deletions packages/web-app-files/src/components/Modals/SetLinkPasswordModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
type="password"
:password-policy="inputPasswordPolicy"
:generate-password-method="inputGeneratePasswordMethod"
:fix-message-line="true"
kulmann marked this conversation as resolved.
Show resolved Hide resolved
:placeholder="link.hasPassword ? '●●●●●●●●' : null"
:error-message="errorMessage"
class="oc-modal-body-input"
Expand Down Expand Up @@ -93,7 +92,7 @@ export default defineComponent({
onInput,
errorMessage,
passwordPolicyService,
inputPasswordPolicy: passwordPolicyService.getPolicy(),
inputPasswordPolicy: passwordPolicyService.getPolicy({ enforcePassword: true }),
inputGeneratePasswordMethod: () => passwordPolicyService.generatePassword(),

// unit tests
Expand Down
Loading