[tests-only] add test download previos version of file. Add check download file

[ScharfViktor]

• A test for this error 2261 is written
• added a check that the file was downloaded successfully

[ownclouders]

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18194/34/1
The following scenarios passed on retry:

• webUISharingPublicManagement/publicLinkIndicator.feature:27

[ownclouders]

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18194/40/1
The following scenarios passed on retry:

• webUISharingExternalToRoot/federationSharing.feature:356

[ownclouders]

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/18194/43/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

[phil-davis]

Note: there are API test scenarios for this issue that are failing in oCIS CI:

#### [downloading an old version of a file returns 501](https://github.com/owncloud/ocis/issues/2261)
-    [apiVersions/fileVersions.feature:437](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiVersions/fileVersions.feature#L437)
-    [apiVersions/fileVersions.feature:455](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiVersions/fileVersions.feature#L455)
-    [apiVersions/fileVersionsSharingToShares.feature:301](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiVersions/fileVersionsSharingToShares.feature#L301)

So the bug is in the server. But I guess it is useful to have a web scenario for this, because when the server bug is fixed, and the API scenarios pass, we then want to know that web UI can actually display and download versions.

[ownclouders]

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18236/24/1
The following scenarios passed on retry:

• webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104
• webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:114

[ownclouders]

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/18236/52/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

[fschade]

as discussed, if the tests run in ci the downloaded files (in selenium) are not available on the test runner.
That means path.join(__dirname, '/../download/', file) will never be successflul.

The best would be to mount a download dir into the selenium image and then path.join(__dirname, '/../download/', file) should work.

Similar how we do it for the files to upload in drone

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[pascalwengerter]

@ScharfViktor I fear this one needs a rebase, can we help you with finalizing this PR?

[ScharfViktor]

@ScharfViktor I fear this one needs a rebase, can we help you with finalizing this PR?

@pascalwengerter yeah, that would be great. I could not figure out how to drone add volume like in docker-compose
volumes: - ./tests/acceptance/download:/home/seluser/Downloads

[pascalwengerter]

@ScharfViktor this needs a big rebase. Can you ping me early next week and we do it together? Or do you want to add it to the smoke tests instead and close (=supersede) this PR?

[phil-davis]

See core PR owncloud/core#39442
That added tests with the ability to download files with chrome browser and then to be able to access the Download directory from within test steps. The oC10 tests added there check that the correct filename downloaded, and check the content of the downloaded files ("raw" txxt files, zip/tar files)

That might give some clues for the test infrastructure setup.

[pascalwengerter]

@ScharfViktor can you maybe shift this test to Playwright? "Real" downloads there work already out of the box so you'd "only" have to figure out how to access the downloaded file's content

[pascalwengerter]

@ScharfViktor can you maybe shift this test to Playwright? "Real" downloads there work already out of the box so you'd "only" have to figure out how to access the downloaded file's content

Plus it'd work locally as well the same it does in CI, without mounting volumes or the likes

[ScharfViktor]

@ScharfViktor can you maybe shift this test to Playwright? "Real" downloads there work already out of the box so you'd "only" have to figure out how to access the downloaded file's content

I agree, it's a good idea))

[ScharfViktor]

See core PR owncloud/core#39442
That added tests with the ability to download files with chrome browser and then to be able to access the Download directory from within test steps. The oC10 tests added there check that the correct filename downloaded, and check the content of the downloaded files ("raw" txxt files, zip/tar files)

@phil-davis thanks for the tip

[ScharfViktor]

Now smoke tests have a good file download check:
we check for file load, file length, and name. We can also check the content of the file.

So I did not duplicate the file download check in the "acceptance" tests.

I moved the check "download previos version" to another task #6038, so as not to bother with the "rebase"