Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] add test download previos version #6038

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

ScharfViktor
Copy link
Contributor

A test for existing error 2261 is written
And added to expected-failures

@update-docs
Copy link

update-docs bot commented Nov 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/20384/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ScharfViktor ScharfViktor changed the title add test download previos version [tests-only] add test download previos version Nov 19, 2021
@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20386/17/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15
    💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers1 https://drone.owncloud.com/owncloud/web/20393/59/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:158

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20393/16/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/20393/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20421/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/20426/67/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:73

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/20426/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20427/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor

@ScharfViktor could you investigate why the tests failed here? :)

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor could you investigate why the tests failed here? :)

Strange things happen here)
When we create a new version in oC10, we get a version counter "0", when we create version 2, the version counter becomes "1". In ocis everything works correctly

@pascalwengerter
Copy link
Contributor

@ScharfViktor could you investigate why the tests failed here? :)

Strange things happen here) When we create a new version in oC10, we get a version counter "0", when we create version 2, the version counter becomes "1". In ocis everything works correctly

I think if you search issues in oCIS/web you should find mentions for this. @individual-it and @phil-davis also should be able to provide more insights on this topic since it for sure already popped up in CI

@individual-it
Copy link
Member

versions tests have often issues because in oC10 a version is only saved once per second. If a file is updated multiple times within one second it will only generate one version.
In web UI tests this was recently fixed by @SwikritiT see #6047

@individual-it
Copy link
Member

the solution will be improved soon to be even more stable, see #6081 and then it should be ported over to the middleware

@pascalwengerter
Copy link
Contributor

@individual-it @ScharfViktor what's the current state here?

@pascalwengerter
Copy link
Contributor

@ScharfViktor could you soft reset your changes git reset --soft HEAD~4 and squash them in one commit? There's some cyrillic letter in the commit messages and too many commits for such a small change anyways :)

@ScharfViktor
Copy link
Contributor Author

@ScharfViktor could you soft reset your changes git reset --soft HEAD~4 and squash them in one commit? There's some cyrillic letter in the commit messages and too many commits for such a small change anyways :)

Yeah sure, I'll do it. I just have to wait until the CI is green.

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/20985/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor

@ScharfViktor could you soft reset your changes git reset --soft HEAD~4 and squash them in one commit? There's some cyrillic letter in the commit messages and too many commits for such a small change anyways :)

Yeah sure, I'll do it. I just have to wait until the CI is green.

That doesn't make too much sense since it would need to run once again after you did it anyways, no?

@ScharfViktor
Copy link
Contributor Author

ScharfViktor commented Dec 13, 2021

The test versions.feature:63 used to work in Osis, because when we created the new version - the number of versions was 0 (it was wrong). Now, when all this was fixed, the test fails. I added tag @skipOnOCIS

steps And the administrator has cleared the versions for all users doesnot work in oCis.

Given('the administrator has cleared the versions for all users', function () { if (client.globals.ocis) { // TODO: decide if we fail on OCIS when a scenario even tries to use this given step return } return occHelper.runOcc(['versions:cleanup']) })

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/20990/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/20990/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/21013/17/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/21071/56/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me, not sure if we need to sort out expected failures after this has been merged

@pascalwengerter pascalwengerter merged commit 94f176c into master Dec 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the downloadPreiosVersion branch December 17, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants