-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y fix visible labels #5969
A11y fix visible labels #5969
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
tag="label" | ||
for="files-collaborators-role-button" | ||
class="oc-label" | ||
>Role</translate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you run yarn lint
in the project please? The linter failed in CI, this command should show you what needs to be changed (and you can yarn lint --fix
to fix it)
<oc-select | ||
v-model="selectedRole" | ||
input-id="files-collaborators-role-button" | ||
class="files-collaborators-role-button-wrapper" | ||
:options="roles" | ||
:clearable="false" | ||
label="label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On owncloud/owncloud-design-system#1530 we have changed the way labels work for the OcSelect
component so you should be able to remove the span above and pass a computed property in the label line you deleted (see owncloud/owncloud-design-system@088159b)
Closing this as outdated, will provide a fix directly on the |
Description
Updated aria-labels to pass accessibility requirements.
Related Issue
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: