Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y fix visible labels #5969

Closed
wants to merge 4 commits into from
Closed

Conversation

stevefrenzel
Copy link

Description

Updated aria-labels to pass accessibility requirements.

Related Issue

How Has This Been Tested?

  • Tested with dev tools in developer environment

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • One test fails but error message is difficult to read and it's not clear what's the problem

@update-docs
Copy link

update-docs bot commented Nov 2, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2021

CLA assistant check
All committers have signed the CLA.

tag="label"
for="files-collaborators-role-button"
class="oc-label"
>Role</translate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run yarn lint in the project please? The linter failed in CI, this command should show you what needs to be changed (and you can yarn lint --fix to fix it)

<oc-select
v-model="selectedRole"
input-id="files-collaborators-role-button"
class="files-collaborators-role-button-wrapper"
:options="roles"
:clearable="false"
label="label"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On owncloud/owncloud-design-system#1530 we have changed the way labels work for the OcSelect component so you should be able to remove the span above and pass a computed property in the label line you deleted (see owncloud/owncloud-design-system@088159b)

@pascalwengerter
Copy link
Contributor

Closing this as outdated, will provide a fix directly on the a11y-updates branch

@pascalwengerter pascalwengerter deleted the a11y-fix-visible-labels branch January 27, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants