-
Notifications
You must be signed in to change notification settings - Fork 19
Fix a11y issues from release 7.1.3 #1530
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…describby Remove aria-described-by in tippy for a11y reasons
Remove click handler from th for sorting
…ilable removed role from tippy
* Add label to OcSelect * OcSelect: Add optionLabel prop which is passed as label to vue-select * Move input-id into additional attributes computed prop Co-authored-by: Dominik Schmidt <[email protected]> Co-authored-by: Benedikt Kulmann <[email protected]>
A11y Change sidebar landmark from header to figure
A11y fix sufficient contrast
feat(color): higher contrast ratio on hover
style(oc-text): switched to same color group Remove underline from breadcrumb hover adjustments
A11y fix sufficient text contrast
Steve Frenzel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@kulmann how do we handle this? Steve had originally signed the CLA and we have commits by him on master also, not sure why it fails now |
CLA was originally signed at the time when the commits were made and we won't be able to cherry-pick any of this to master anyway. So IMO it just looks ugly on this PR now, which is only cosmetic. |
DO NOT MERGE
This PR fixes the following a11y issues, branching off from version 7.1.3
Related fixes:
a
so far)